Title: [287274] trunk/Source/WebKit
- Revision
- 287274
- Author
- wenson_hs...@apple.com
- Date
- 2021-12-20 13:36:06 -0800 (Mon, 20 Dec 2021)
Log Message
Minor cleanup in AuthenticationServicesCoreSPI.h
https://bugs.webkit.org/show_bug.cgi?id=234514
Reviewed by Devin Rousso.
When using the Apple internal SDK, directly import <AuthenticationServicesCore/ASCWebKitSPISupport.h> instead of
relying on forward declarations (or, in this case, relying on a previous unified source to import the header
through WebKitAdditions).
Additionally leave a FIXME to clean up the rest of this file by importing the private headers directly when
building with the internal SDK (and falling back to forward declarations in non-internal builds).
* Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (287273 => 287274)
--- trunk/Source/WebKit/ChangeLog 2021-12-20 21:02:31 UTC (rev 287273)
+++ trunk/Source/WebKit/ChangeLog 2021-12-20 21:36:06 UTC (rev 287274)
@@ -1,3 +1,19 @@
+2021-12-20 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Minor cleanup in AuthenticationServicesCoreSPI.h
+ https://bugs.webkit.org/show_bug.cgi?id=234514
+
+ Reviewed by Devin Rousso.
+
+ When using the Apple internal SDK, directly import <AuthenticationServicesCore/ASCWebKitSPISupport.h> instead of
+ relying on forward declarations (or, in this case, relying on a previous unified source to import the header
+ through WebKitAdditions).
+
+ Additionally leave a FIXME to clean up the rest of this file by importing the private headers directly when
+ building with the internal SDK (and falling back to forward declarations in non-internal builds).
+
+ * Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
+
2021-12-20 Youenn Fablet <you...@apple.com>
Improve UserMediaPermissionRequestManagerProxy logging
Modified: trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h (287273 => 287274)
--- trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2021-12-20 21:02:31 UTC (rev 287273)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2021-12-20 21:36:06 UTC (rev 287274)
@@ -27,6 +27,18 @@
#if HAVE(ASC_AUTH_UI) || HAVE(UNIFIED_ASC_AUTH_UI)
+#if USE(APPLE_INTERNAL_SDK)
+#import <AuthenticationServicesCore/ASCWebKitSPISupport.h>
+#else
+@interface ASCWebKitSPISupport : NSObject
+@property (class, nonatomic) BOOL shouldUseAlternateCredentialStore;
+@end
+#endif
+
+// FIXME: Most of the forward declarations below should be behind a non-Apple-internal SDK compile-time flag.
+// When building with an Apple-internal SDK, we should instead import the private headers directly from the
+// AuthenticationServicesCore framework.
+
NS_ASSUME_NONNULL_BEGIN
@class LAContext;
@@ -343,6 +355,4 @@
NS_ASSUME_NONNULL_END
-//#endif // USE(APPLE_INTERNAL_SDK)
-
-#endif // HAVE(ASC_AUTH_UI)
+#endif // HAVE(ASC_AUTH_UI) || HAVE(UNIFIED_ASC_AUTH_UI)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
