Title: [287822] trunk
- Revision
- 287822
- Author
- grao...@webkit.org
- Date
- 2022-01-09 10:13:26 -0800 (Sun, 09 Jan 2022)
Log Message
translate() function in transform property should remove trailing 0 value when parsing
https://bugs.webkit.org/show_bug.cgi?id=235016
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Mark WPT progression.
* web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:
Source/WebCore:
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeTransformValue):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287821 => 287822)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-09 18:06:02 UTC (rev 287821)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-09 18:13:26 UTC (rev 287822)
@@ -1,3 +1,14 @@
+2022-01-09 Antoine Quint <grao...@webkit.org>
+
+ translate() function in transform property should remove trailing 0 value when parsing
+ https://bugs.webkit.org/show_bug.cgi?id=235016
+
+ Reviewed by Antti Koivisto.
+
+ Mark WPT progression.
+
+ * web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:
+
2022-01-08 Antoine Quint <grao...@webkit.org>
[Web Animations] getKeyframes() for a CSS Animation should not use computed style for keyframes
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt (287821 => 287822)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt 2022-01-09 18:06:02 UTC (rev 287821)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt 2022-01-09 18:13:26 UTC (rev 287822)
@@ -22,6 +22,6 @@
FAIL KeyframeEffect.getKeyframes() returns expected values for animations with CSS variables as keyframe values assert_equals: value for 'transform' on Keyframe #1 should match expected "translate(100px)" but got "matrix(1, 0, 0, 1, 100, 0)"
PASS KeyframeEffect.getKeyframes() returns expected values for animations with CSS variables as keyframe values in a shorthand property
PASS KeyframeEffect.getKeyframes() returns expected values for animations with a CSS variable which is overriden by the value in keyframe
-FAIL KeyframeEffect.getKeyframes() returns expected values for animations with only custom property in a keyframe assert_equals: value for 'transform' on Keyframe #0 should match expected "translate(100px)" but got "translate(100px, 0px)"
+PASS KeyframeEffect.getKeyframes() returns expected values for animations with only custom property in a keyframe
PASS KeyframeEffect.getKeyframes() reflects changes to @keyframes rules
Modified: trunk/Source/WebCore/ChangeLog (287821 => 287822)
--- trunk/Source/WebCore/ChangeLog 2022-01-09 18:06:02 UTC (rev 287821)
+++ trunk/Source/WebCore/ChangeLog 2022-01-09 18:13:26 UTC (rev 287822)
@@ -1,3 +1,13 @@
+2022-01-09 Antoine Quint <grao...@webkit.org>
+
+ translate() function in transform property should remove trailing 0 value when parsing
+ https://bugs.webkit.org/show_bug.cgi?id=235016
+
+ Reviewed by Antti Koivisto.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeTransformValue):
+
2022-01-09 Sam Weinig <wei...@apple.com>
Add helpers to access CoreGraphics color spaces more easily in generic contexts
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (287821 => 287822)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2022-01-09 18:06:02 UTC (rev 287821)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2022-01-09 18:13:26 UTC (rev 287822)
@@ -1938,6 +1938,11 @@
parsedValue = consumeLengthOrPercent(args, cssParserMode, ValueRange::All);
if (!parsedValue)
return nullptr;
+ if (is<CSSPrimitiveValue>(parsedValue)) {
+ auto isZero = downcast<CSSPrimitiveValue>(*parsedValue).isZero();
+ if (isZero && *isZero)
+ parsedValue = nullptr;
+ }
}
break;
case CSSValueTranslateZ:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
