Title: [290695] branches/safari-613-branch/Source/ThirdParty/ANGLE
- Revision
- 290695
- Author
- alanc...@apple.com
- Date
- 2022-03-01 15:49:40 -0800 (Tue, 01 Mar 2022)
Log Message
Cherry-pick r290011. rdar://problem/89024095
REGRESSION (iOS 15.4b3): Catastrophic (20x) performance regression in texImage2D from mp4 video
https://bugs.webkit.org/show_bug.cgi?id=236699
Patch by Kimmo Kinnunen <kkinnu...@apple.com> on 2022-02-17
Reviewed by Darin Adler.
Disable the validation for IOSurface pixel formats.
We might pass non-public formats that do not have sensible IOSurfaceGetBytesPerElementOfPlane
to verify with this logic.
Will add test in bug 236759.
Previous bugs of the same:
EAGL:
Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
bug 218637, r273582, 234632@main
CGL:
REGRESSION(Safari 15, BigSur): Poor video texture upload performance with MacBook M1, ANGLE OpenGL backend
bug 232235, r286960, 245183@main
* src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:
(rx::IOSurfaceSurfaceMtl::ValidateAttributes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/ThirdParty/ANGLE/ChangeLog (290694 => 290695)
--- branches/safari-613-branch/Source/ThirdParty/ANGLE/ChangeLog 2022-03-01 23:49:37 UTC (rev 290694)
+++ branches/safari-613-branch/Source/ThirdParty/ANGLE/ChangeLog 2022-03-01 23:49:40 UTC (rev 290695)
@@ -1,3 +1,56 @@
+2022-03-01 Russell Epstein <repst...@apple.com>
+
+ Cherry-pick r290011. rdar://problem/89024095
+
+ REGRESSION (iOS 15.4b3): Catastrophic (20x) performance regression in texImage2D from mp4 video
+ https://bugs.webkit.org/show_bug.cgi?id=236699
+
+ Patch by Kimmo Kinnunen <kkinnu...@apple.com> on 2022-02-17
+ Reviewed by Darin Adler.
+
+ Disable the validation for IOSurface pixel formats.
+ We might pass non-public formats that do not have sensible IOSurfaceGetBytesPerElementOfPlane
+ to verify with this logic.
+
+ Will add test in bug 236759.
+
+ Previous bugs of the same:
+ EAGL:
+ Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
+ bug 218637, r273582, 234632@main
+ CGL:
+ REGRESSION(Safari 15, BigSur): Poor video texture upload performance with MacBook M1, ANGLE OpenGL backend
+ bug 232235, r286960, 245183@main
+
+ * src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:
+ (rx::IOSurfaceSurfaceMtl::ValidateAttributes):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-02-17 Kimmo Kinnunen <kkinnu...@apple.com>
+
+ REGRESSION (iOS 15.4b3): Catastrophic (20x) performance regression in texImage2D from mp4 video
+ https://bugs.webkit.org/show_bug.cgi?id=236699
+
+ Reviewed by Darin Adler.
+
+ Disable the validation for IOSurface pixel formats.
+ We might pass non-public formats that do not have sensible IOSurfaceGetBytesPerElementOfPlane
+ to verify with this logic.
+
+ Will add test in bug 236759.
+
+ Previous bugs of the same:
+ EAGL:
+ Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
+ bug 218637, r273582, 234632@main
+ CGL:
+ REGRESSION(Safari 15, BigSur): Poor video texture upload performance with MacBook M1, ANGLE OpenGL backend
+ bug 232235, r286960, 245183@main
+
+ * src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:
+ (rx::IOSurfaceSurfaceMtl::ValidateAttributes):
+
2022-01-24 Alan Coon <alanc...@apple.com>
Cherry-pick r288105. rdar://problem/87656387
Modified: branches/safari-613-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm (290694 => 290695)
--- branches/safari-613-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm 2022-03-01 23:49:37 UTC (rev 290694)
+++ branches/safari-613-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm 2022-03-01 23:49:40 UTC (rev 290695)
@@ -210,12 +210,10 @@
return false;
}
- // Check that the format matches this IOSurface plane
- if (IOSurfaceGetBytesPerElementOfPlane(ioSurface, plane) !=
- kIOSurfaceFormats[formatIndex].componentBytes)
- {
- return false;
- }
+ // FIXME: Check that the format matches this IOSurface plane for pixel formats that we know of.
+ // We could map IOSurfaceGetPixelFormat to expected type plane and format type.
+ // However, the caller might supply us non-public pixel format, which makes exhaustive checks
+ // problematic.
return true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
