Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291558 => 291559)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-21 16:29:00 UTC (rev 291559)
@@ -1,3 +1,15 @@
+2022-03-21 Jonathan Bedard <jbed...@apple.com>
+
+ Unreviewed, reverting r291558.
+
+ Exceeded GitHub file size limit
+
+ Reverted changeset:
+
+ "Enable PGO when building for release and production"
+ https://bugs.webkit.org/show_bug.cgi?id=238119
+ https://commits.webkit.org/r291558
+
2022-03-21 Wenson Hsieh <wenson_hs...@apple.com>
Enable PGO when building for release and production
Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (291558 => 291559)
--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -106,7 +106,7 @@
GCC_WARN_UNUSED_VARIABLE = YES;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
PREBINDING = NO;
-WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety -Wno-profile-instr-out-of-date -Wno-profile-instr-unprofiled;
+WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety;
HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (291558 => 291559)
--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -40,15 +40,10 @@
SECTORDER_FLAGS_Production[sdk=iphoneos*] = -Wl,-order_file,$(SDKROOT)/AppleInternal/OrderFiles/_javascript_Core.order;
SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,_javascript_Core.order;
-PROFILE_DATA_FLAGS = $(PROFILE_DATA_FLAGS_$(CONFIGURATION));
-PROFILE_DATA_FLAGS_Production = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_Release = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_YES = -fprofile-instr-use=$(SRCROOT)/Profiling/_javascript_Core.profdata;
-
GCC_PREFIX_HEADER = _javascript_CorePrefix.h;
GCC_SYMBOLS_PRIVATE_EXTERN = YES;
OTHER_CFLAGS = $(inherited) -fno-slp-vectorize --system-header-prefix=unicode/ -D__STDC_WANT_LIB_EXT1__=1;
-OTHER_CPLUSPLUSFLAGS = $(inherited) -fno-slp-vectorize --system-header-prefix=unicode/ $(PROFILE_DATA_FLAGS);
+OTHER_CPLUSPLUSFLAGS = $(inherited) -fno-slp-vectorize --system-header-prefix=unicode/;
HEADER_SEARCH_PATHS = "${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core" $(HEADER_SEARCH_PATHS);
INFOPLIST_FILE = Info.plist;
INSTALL_PATH = $(INSTALL_PATH_PREFIX)$(_javascript_CORE_FRAMEWORKS_DIR);
Modified: trunk/Source/WebCore/ChangeLog (291558 => 291559)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 16:29:00 UTC (rev 291559)
@@ -1,3 +1,15 @@
+2022-03-21 Jonathan Bedard <jbed...@apple.com>
+
+ Unreviewed, reverting r291558.
+
+ Exceeded GitHub file size limit
+
+ Reverted changeset:
+
+ "Enable PGO when building for release and production"
+ https://bugs.webkit.org/show_bug.cgi?id=238119
+ https://commits.webkit.org/r291558
+
2022-03-21 Wenson Hsieh <wenson_hs...@apple.com>
Enable PGO when building for release and production
Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (291558 => 291559)
--- trunk/Source/WebCore/Configurations/Base.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -90,7 +90,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
-WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wno-unknown-warning-option -Wliteral-conversion -Wthread-safety -Wno-profile-instr-out-of-date -Wno-profile-instr-unprofiled;
+WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wno-unknown-warning-option -Wliteral-conversion -Wthread-safety;
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base))
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (291558 => 291559)
--- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -29,13 +29,6 @@
GCC_PREFIX_HEADER = WebCorePrefix.h;
GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) BUILDING_WEBKIT GL_SILENCE_DEPRECATION=1 GLES_SILENCE_DEPRECATION=1 $(inherited);
-PROFILE_DATA_FLAGS = $(PROFILE_DATA_FLAGS_$(CONFIGURATION));
-PROFILE_DATA_FLAGS_Production = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_Release = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_YES = -fprofile-instr-use=$(SRCROOT)/Profiling/WebCore.profdata;
-
-OTHER_CPLUSPLUSFLAGS = $(inherited) $(PROFILE_DATA_FLAGS);
-
WK_PRIVATE_FRAMEWORKS_DIR = $(WK_PRIVATE_FRAMEWORKS_DIR_$(USE_INTERNAL_SDK));
WK_PRIVATE_FRAMEWORKS_DIR_[sdk=macos*] = $(PROJECT_DIR)/../../WebKitLibraries/WebKitPrivateFrameworkStubs/Mac/$(TARGET_MAC_OS_X_VERSION_MAJOR);
WK_PRIVATE_FRAMEWORKS_DIR_[sdk=iphone*] = $(PROJECT_DIR)/../../WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/$(WK_TARGET_IOS_VERSION_MAJOR);
Modified: trunk/Source/WebKit/ChangeLog (291558 => 291559)
--- trunk/Source/WebKit/ChangeLog 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/WebKit/ChangeLog 2022-03-21 16:29:00 UTC (rev 291559)
@@ -1,3 +1,15 @@
+2022-03-21 Jonathan Bedard <jbed...@apple.com>
+
+ Unreviewed, reverting r291558.
+
+ Exceeded GitHub file size limit
+
+ Reverted changeset:
+
+ "Enable PGO when building for release and production"
+ https://bugs.webkit.org/show_bug.cgi?id=238119
+ https://commits.webkit.org/r291558
+
2022-03-21 Wenson Hsieh <wenson_hs...@apple.com>
Enable PGO when building for release and production
Modified: trunk/Source/WebKit/Configurations/Base.xcconfig (291558 => 291559)
--- trunk/Source/WebKit/Configurations/Base.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/WebKit/Configurations/Base.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -94,7 +94,7 @@
GCC_WARN_UNUSED_VARIABLE = YES;
OTHER_MIGFLAGS = -F$(BUILT_PRODUCTS_DIR);
PREBINDING = NO;
-WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety -Wno-profile-instr-out-of-date -Wno-profile-instr-unprofiled;
+WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety;
SWIFT_VERSION = 5.0;
Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (291558 => 291559)
--- trunk/Source/WebKit/Configurations/WebKit.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -28,13 +28,6 @@
PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
INFOPLIST_FILE = Info.plist;
-PROFILE_DATA_FLAGS = $(PROFILE_DATA_FLAGS_$(CONFIGURATION));
-PROFILE_DATA_FLAGS_Production = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_Release = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_YES = -fprofile-instr-use=$(SRCROOT)/Profiling/WebKit.profdata;
-
-OTHER_CPLUSPLUSFLAGS = $(inherited) $(PROFILE_DATA_FLAGS);
-
DEFINES_MODULE = YES;
MODULEMAP_FILE = $(MODULEMAP_FILE_$(WK_COCOA_TOUCH));
MODULEMAP_FILE_cocoatouch = Modules/iOS.modulemap;
