Title: [291931] trunk/Source/WebKit
- Revision
- 291931
- Author
- simon.fra...@apple.com
- Date
- 2022-03-25 20:29:23 -0700 (Fri, 25 Mar 2022)
Log Message
Temporarily disable assertion in MessageReceiveQueueMap::addImpl()
https://bugs.webkit.org/show_bug.cgi?id=238397
Unreviewed followup: similarly change the assertion in remove() into a log.
* Platform/IPC/MessageReceiveQueueMap.cpp:
(IPC::MessageReceiveQueueMap::remove):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (291930 => 291931)
--- trunk/Source/WebKit/ChangeLog 2022-03-26 03:05:18 UTC (rev 291930)
+++ trunk/Source/WebKit/ChangeLog 2022-03-26 03:29:23 UTC (rev 291931)
@@ -1,3 +1,13 @@
+2022-03-25 Simon Fraser <simon.fra...@apple.com>
+
+ Temporarily disable assertion in MessageReceiveQueueMap::addImpl()
+ https://bugs.webkit.org/show_bug.cgi?id=238397
+
+ Unreviewed followup: similarly change the assertion in remove() into a log.
+
+ * Platform/IPC/MessageReceiveQueueMap.cpp:
+ (IPC::MessageReceiveQueueMap::remove):
+
2022-03-25 Commit Queue <commit-qu...@webkit.org>
Unreviewed, reverting r291884.
Modified: trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp (291930 => 291931)
--- trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp 2022-03-26 03:05:18 UTC (rev 291930)
+++ trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp 2022-03-26 03:29:23 UTC (rev 291931)
@@ -42,7 +42,10 @@
void MessageReceiveQueueMap::remove(ReceiverName receiverName, uint64_t destinationID)
{
auto key = std::make_pair(static_cast<uint8_t>(receiverName), destinationID);
- ASSERT(m_queues.contains(key));
+ if (!m_queues.contains(key)) {
+ // FIXME: This should be an assertion. See webkit.org/b/237674 and webkit.org/b/238391.
+ ALWAYS_LOG_WITH_STREAM(stream << "MessageReceiveQueueMap::remove - failed to remove receiver " << static_cast<uint8_t>(receiverName) << " with destination " << destinationID);
+ }
m_queues.remove(key);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
