Title: [293666] trunk/JSTests
- Revision
- 293666
- Author
- ange...@igalia.com
- Date
- 2022-05-02 09:52:55 -0700 (Mon, 02 May 2022)
Log Message
new-largeish-contiguous-array-with-size.js: pick up leakFactor
https://bugs.webkit.org/show_bug.cgi?id=239963
Unreviewed gardening.
The //@ directives are implemented imperatively, so requireOptions
only has any effect if it precedes the run* statement. Also,
s/var leakFactor/leakFactor/ to avoid running into this:
Exception: SyntaxError: Can't create duplicate variable: 'leakFactor'
With this fix, the leakFactor works as intended -- no failures in 200+
iterations.
* stress/new-largeish-contiguous-array-with-size.js:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (293665 => 293666)
--- trunk/JSTests/ChangeLog 2022-05-02 16:29:48 UTC (rev 293665)
+++ trunk/JSTests/ChangeLog 2022-05-02 16:52:55 UTC (rev 293666)
@@ -1,3 +1,21 @@
+2022-05-02 Angelos Oikonomopoulos <ange...@igalia.com>
+
+ new-largeish-contiguous-array-with-size.js: pick up leakFactor
+ https://bugs.webkit.org/show_bug.cgi?id=239963
+
+ Unreviewed gardening.
+
+ The //@ directives are implemented imperatively, so requireOptions
+ only has any effect if it precedes the run* statement. Also,
+ s/var leakFactor/leakFactor/ to avoid running into this:
+
+ Exception: SyntaxError: Can't create duplicate variable: 'leakFactor'
+
+ With this fix, the leakFactor works as intended -- no failures in 200+
+ iterations.
+
+ * stress/new-largeish-contiguous-array-with-size.js:
+
2022-04-29 Yury Semikhatsky <yu...@chromium.org>
Format time zone name using ICU instead of platform calls
Modified: trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js (293665 => 293666)
--- trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js 2022-05-02 16:29:48 UTC (rev 293665)
+++ trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js 2022-05-02 16:52:55 UTC (rev 293666)
@@ -1,7 +1,7 @@
// We only need one run of this with any GC or JIT strategy. This test is not particularly fast.
// Unfortunately, it needs to run for a while to test the thing it's testing.
+//@ requireOptions("-e", "let leakFactor=3") if $architecture == "mips"
//@ runWithRAMSize(10000000)
-//@ requireOptions("-e", "let leakFactor=3") if $architecture == "mips"
//@ slow!
// Note: Due to the conservative stack scanning, it is possible that arbitrary
@@ -13,7 +13,7 @@
// Arrays allocated in the loop. This would then cause the final check on the
// post GC heap size to fail, as some of the arrays cannot be collected, so ...
// increasing leniency on platforms where this manifests.
-var leakFactor = typeof(leakFactor) === 'undefined' ? 1 : leakFactor;
+leakFactor = typeof(leakFactor) === 'undefined' ? 1 : leakFactor;
function foo(x) {
return new Array(x);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
