Title: [293734] trunk/Source/WebKit
Revision
293734
Author
pvol...@apple.com
Date
2022-05-03 11:47:57 -0700 (Tue, 03 May 2022)

Log Message

[iOS][WP] Only block IOKit access if all GPUP features are enabled
https://bugs.webkit.org/show_bug.cgi?id=240010

Reviewed by Tim Horton.

Only block IOKit access in the WebContent process' sandbox on iOS if all GPUP features are enabled.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (293733 => 293734)


--- trunk/Source/WebKit/ChangeLog	2022-05-03 18:25:46 UTC (rev 293733)
+++ trunk/Source/WebKit/ChangeLog	2022-05-03 18:47:57 UTC (rev 293734)
@@ -1,5 +1,17 @@
 2022-05-03  Per Arne Vollan  <pvol...@apple.com>
 
+        [iOS][WP] Only block IOKit access if all GPUP features are enabled
+        https://bugs.webkit.org/show_bug.cgi?id=240010
+
+        Reviewed by Tim Horton.
+
+        Only block IOKit access in the WebContent process' sandbox on iOS if all GPUP features are enabled.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::m_appHighlightsVisible):
+
+2022-05-03  Per Arne Vollan  <pvol...@apple.com>
+
         [iOS][GPUP] Remove Mach sandbox extensions for non browser clients
         https://bugs.webkit.org/show_bug.cgi?id=240008
 

Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (293733 => 293734)


--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2022-05-03 18:25:46 UTC (rev 293733)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2022-05-03 18:47:57 UTC (rev 293734)
@@ -919,7 +919,16 @@
         // This call should be replaced with proper API when available.
         CFPreferencesGetAppIntegerValue(CFSTR("key"), CFSTR("com.apple.WebKit.WebContent.AppCacheDisabled"), nullptr);
     }
-    if (parameters.store.getBoolValueForKey(WebPreferencesKey::blockIOKitInWebContentSandboxKey()))
+
+    auto blockIOKit = parameters.store.getBoolValueForKey(WebPreferencesKey::blockIOKitInWebContentSandboxKey())
+#if ENABLE(WEBGL)
+        && m_shouldRenderWebGLInGPUProcess
+#endif
+        && m_shouldRenderCanvasInGPUProcess
+        && m_shouldRenderDOMInGPUProcess
+        && m_shouldPlayMediaInGPUProcess;
+
+    if (blockIOKit)
         CFPreferencesGetAppIntegerValue(CFSTR("key"), CFSTR("com.apple.WebKit.WebContent.BlockIOKitInWebContentSandbox"), nullptr);
 #endif
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to