Title: [294509] trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
- Revision
- 294509
- Author
- basuke.suz...@sony.com
- Date
- 2022-05-19 15:43:55 -0700 (Thu, 19 May 2022)
Log Message
[Curl] Suppress warning of unused enum value in switch statement.
https://bugs.webkit.org/show_bug.cgi?id=240672
Reviewed by Fujii Hironori.
Just after the request object creation, the state is WaitingForStart. It is better
the code explicitly takes care of this fact. Also moving the assignment to the state
inside the switch statement denotes the state is changing to the response of previous
state.
No new tests. Covered by existing tests.
* platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::start):
Canonical link: https://commits.webkit.org/250766@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (294508 => 294509)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2022-05-19 22:37:38 UTC (rev 294508)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2022-05-19 22:43:55 UTC (rev 294509)
@@ -116,10 +116,11 @@
[[fallthrough]];
case StartState::StartSuspended:
return;
+ case StartState::WaitingForStart:
+ m_startState = StartState::DidStart;
+ break;
}
- m_startState = StartState::DidStart;
-
if (m_request.url().isLocalFile())
invokeDidReceiveResponseForFile(m_request.url());
else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes