Title: [294949] trunk/Source/WebCore
- Revision
- 294949
- Author
- sihui_...@apple.com
- Date
- 2022-05-27 12:54:52 -0700 (Fri, 27 May 2022)
Log Message
Stop exposing ApplicationCache API if it is not enabled
https://bugs.webkit.org/show_bug.cgi?id=241000
Reviewed by Chris Dumez.
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/loader/appcache/DOMApplicationCache.idl:
* Source/WebCore/page/DOMWindow.idl:
Canonical link: https://commits.webkit.org/251057@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (294948 => 294949)
--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2022-05-27 19:29:41 UTC (rev 294948)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2022-05-27 19:54:52 UTC (rev 294949)
@@ -50,6 +50,7 @@
macro(ApplePaySession) \
macro(ApplePaySetup) \
macro(ApplePaySetupFeature) \
+ macro(ApplicationCache) \
macro(AttachmentElement) \
macro(Audio) \
macro(AudioBuffer) \
@@ -421,6 +422,7 @@
macro(abortAlgorithm) \
macro(abortSteps) \
macro(appendFromJS) \
+ macro(applicationCache) \
macro(associatedReadableByteStreamController) \
macro(autoAllocateChunkSize) \
macro(backingMap) \
Modified: trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl (294948 => 294949)
--- trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl 2022-05-27 19:29:41 UTC (rev 294948)
+++ trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl 2022-05-27 19:54:52 UTC (rev 294949)
@@ -29,7 +29,8 @@
DoNotCheckConstants,
GenerateIsReachable=ReachableFromDOMWindow,
InterfaceName=ApplicationCache,
- Exposed=Window
+ Exposed=Window,
+ EnabledBySetting=OfflineWebApplicationCacheEnabled
] interface DOMApplicationCache : EventTarget {
// update status
const unsigned short UNCACHED = 0;
Modified: trunk/Source/WebCore/page/DOMWindow.idl (294948 => 294949)
--- trunk/Source/WebCore/page/DOMWindow.idl 2022-05-27 19:29:41 UTC (rev 294948)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2022-05-27 19:54:52 UTC (rev 294949)
@@ -78,7 +78,7 @@
// the user agent
readonly attribute Navigator navigator;
// FIXME: This is specified to be [SecureContext]
- readonly attribute DOMApplicationCache applicationCache;
+ [EnabledBySetting=OfflineWebApplicationCacheEnabled] readonly attribute DOMApplicationCache applicationCache;
// user prompts
undefined alert();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
