Title: [294950] trunk/Source
- Revision
- 294950
- Author
- j_pas...@apple.com
- Date
- 2022-05-27 13:14:24 -0700 (Fri, 27 May 2022)
Log Message
[WebAuthn] Forward declare ASC SPI for internal needs.
https://bugs.webkit.org/show_bug.cgi?id=240928
rdar://problem/93930713
Reviewed by Brent Fulgham.
This fixes the build after an internal change for older macOS.
* Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
Remove unused import that isn't present in older macOS sdk.
Canonical link: https://commits.webkit.org/251058@main
Modified Paths
Diff
Modified: trunk/Source/WTF/wtf/PlatformHave.h (294949 => 294950)
--- trunk/Source/WTF/wtf/PlatformHave.h 2022-05-27 19:54:52 UTC (rev 294949)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2022-05-27 20:14:24 UTC (rev 294950)
@@ -830,6 +830,11 @@
#define HAVE_ASC_AUTH_UI 1
#endif
+#if PLATFORM(IOS) \
+ || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000)
+#define HAVE_ASC_WEBKIT_SPI 1
+#endif
+
#if PLATFORM(MAC)
#if !defined(HAVE_MT_PLUGIN_FORMAT_READER)
#define HAVE_MT_PLUGIN_FORMAT_READER 1
Modified: trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h (294949 => 294950)
--- trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2022-05-27 19:54:52 UTC (rev 294949)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2022-05-27 20:14:24 UTC (rev 294950)
@@ -27,7 +27,7 @@
#if HAVE(ASC_AUTH_UI) || HAVE(UNIFIED_ASC_AUTH_UI)
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && HAVE(ASC_WEBKIT_SPI)
#import <AuthenticationServicesCore/ASCWebKitSPISupport.h>
#else
@interface ASCWebKitSPISupport : NSObject
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (294949 => 294950)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm 2022-05-27 19:54:52 UTC (rev 294949)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm 2022-05-27 20:14:24 UTC (rev 294950)
@@ -32,7 +32,6 @@
#import "WKError.h"
#import "WebAuthenticationRequestData.h"
#import "WebPageProxy.h"
-#import <AuthenticationServices/ASCOSEConstants.h>
#import <WebCore/AuthenticatorAttachment.h>
#import <WebCore/AuthenticatorResponseData.h>
#import <WebCore/BufferSource.h>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
