Title: [294967] trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
- Revision
- 294967
- Author
- drou...@apple.com
- Date
- 2022-05-27 16:52:53 -0700 (Fri, 27 May 2022)
Log Message
Web Inspector: Timelines: switching between Events/Frames while editing instruments leaves the UI in a broken state
https://bugs.webkit.org/show_bug.cgi?id=218700
<rdar://problem/71180148>
Reviewed by Patrick Angle.
* Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:
(WI.TimelineOverview.prototype.set viewMode):
(WI.TimelineOverview.prototype._viewModeDidChange):
Forcibly stop editing instruments when switching between Events/Frames. Note that this will save the
current state of edited instruments, so no changes will be lost.
Canonical link: https://commits.webkit.org/251071@main
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (294966 => 294967)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2022-05-27 23:40:43 UTC (rev 294966)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2022-05-27 23:52:53 UTC (rev 294967)
@@ -174,9 +174,6 @@
set viewMode(x)
{
- if (this._editingInstruments)
- return;
-
if (this._viewMode === x)
return;
@@ -824,6 +821,8 @@
_viewModeDidChange()
{
+ this._stopEditingInstruments();
+
let startTime = 0;
let isRenderingFramesMode = this._viewMode === WI.TimelineOverview.ViewMode.RenderingFrames;
if (isRenderingFramesMode) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
