Title: [295775] trunk
Revision
295775
Author
an...@apple.com
Date
2022-06-23 05:40:44 -0700 (Thu, 23 Jun 2022)

Log Message

REGRESSION (251257@main): [ macOS wk1 ] fast/replaced/encrypted-pdf-as-object-and-embed.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=241879
<rdar://95728601>

Reviewed by Antoine Quint.

* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):

Null test the view. It can be null on WK1.

Canonical link: https://commits.webkit.org/251780@main

Modified Paths

Diff

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (295774 => 295775)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-06-23 11:58:08 UTC (rev 295774)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-06-23 12:40:44 UTC (rev 295775)
@@ -1852,5 +1852,3 @@
 webkit.org/b/241266 compositing/video/video-border-radius.html [ Pass Timeout ]
 
 webkit.org/b/241376 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-035.html [ Pass ImageOnlyFailure ]
-
-webkit.org/b/241879 fast/replaced/encrypted-pdf-as-object-and-embed.html [ Pass Crash ]

Modified: trunk/Source/WebCore/style/StyleScope.cpp (295774 => 295775)


--- trunk/Source/WebCore/style/StyleScope.cpp	2022-06-23 11:58:08 UTC (rev 295774)
+++ trunk/Source/WebCore/style/StyleScope.cpp	2022-06-23 12:40:44 UTC (rev 295775)
@@ -794,8 +794,10 @@
 bool Scope::updateQueryContainerState(QueryContainerUpdateContext& context)
 {
     ASSERT(!m_shadowRoot);
-    ASSERT(m_document.renderView());
 
+    if (!m_document.renderView())
+        return false;
+
     auto previousStates = WTFMove(m_queryContainerStates);
     m_queryContainerStates.clear();
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to