[webkit-changes] [87678] trunk

Mon, 30 May 2011 00:22:29 -0700

Title: [87678] trunk
Revision
87678
Author
aba...@webkit.org
Date
2011-05-30 00:22:21 -0700 (Mon, 30 May 2011)

Log Message

2011-05-30  Sheriff Bot  <webkit.review....@gmail.com>

        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-30  Sheriff Bot  <webkit.review....@gmail.com>

        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (87677 => 87678)


--- trunk/LayoutTests/ChangeLog	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/LayoutTests/ChangeLog	2011-05-30 07:22:21 UTC (rev 87678)
@@ -1,3 +1,19 @@
+2011-05-30  Sheriff Bot  <webkit.review....@gmail.com>
+
+        Unreviewed, rolling out r87618.
+        http://trac.webkit.org/changeset/87618
+        https://bugs.webkit.org/show_bug.cgi?id=61720
+
+        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
+        abarth|gardener on #webkit).
+
+        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
+        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
+        * platform/gtk/Skipped:
+        * platform/mac/Skipped:
+        * platform/qt/Skipped:
+        * platform/win/Skipped:
+
 2011-05-29  Yuta Kitamura  <yu...@chromium.org>
 
         Reviewed by Kent Tamura.

Deleted: trunk/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt (87677 => 87678)


--- trunk/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt	2011-05-30 07:22:21 UTC (rev 87678)
@@ -1,2 +0,0 @@
-PASS we didn't crash.
-This test makes sure that a single prefetch element is not a client of multiple cachedresources at the same time; by repeatedly changing an existing link element, we will induce a double-notify bug if that element is not releasing its cachedresource on update.

Deleted: trunk/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients.html (87677 => 87678)


--- trunk/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients.html	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients.html	2011-05-30 07:22:21 UTC (rev 87678)
@@ -1,38 +0,0 @@
-<html>
-<body _onload_="many_link_updates(50);setTimeout('done();',0)">
-<div id="console"></div>
-<script src=""
-<script>
-
-function addLink(url, rel) {
-    var link = document.getElementById(rel) ||
-               document.createElement('link');
-    link.id = rel;
-    link.rel = rel;
-    link.href = ""
-    document.body.appendChild(link);
-}
-
-function many_link_updates(iter) {
-    for(var i=0;i<iter;++i) {
-        addLink("many_link_updates_" + i + ".html", "prefetch");
-    }
-}
-
-function done() {
-    testPassed("we didn't crash.");
-    if (window.layoutTestController) {
-        layoutTestController.notifyDone();
-    }
-}
-
-if (window.layoutTestController) {
-    layoutTestController.waitUntilDone(); 
-    layoutTestController.dumpAsText();
-}
-</script>
-<p>This test makes sure that a single prefetch element is not a client of multiple cachedresources at the same time; by 
-repeatedly changing an existing link element, we will induce a double-notify bug if that element is not releasing its
-cachedresource on update.</p>
-</body>
-</html>

Modified: trunk/LayoutTests/platform/gtk/Skipped (87677 => 87678)


--- trunk/LayoutTests/platform/gtk/Skipped	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-05-30 07:22:21 UTC (rev 87678)
@@ -972,10 +972,9 @@
 # Link prefetch is disabled by default
 fast/dom/HTMLLinkElement/link-and-subresource-test.html
 fast/dom/HTMLLinkElement/prefetch.html
-fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
+fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html

Modified: trunk/LayoutTests/platform/mac/Skipped (87677 => 87678)


--- trunk/LayoutTests/platform/mac/Skipped	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/LayoutTests/platform/mac/Skipped	2011-05-30 07:22:21 UTC (rev 87678)
@@ -182,7 +182,6 @@
 fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html
 http/tests/misc/link-rel-prefetch-and-subresource.html

Modified: trunk/LayoutTests/platform/qt/Skipped (87677 => 87678)


--- trunk/LayoutTests/platform/qt/Skipped	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-05-30 07:22:21 UTC (rev 87678)
@@ -1948,7 +1948,6 @@
 fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html
 http/tests/misc/link-rel-prefetch-and-subresource.html

Modified: trunk/LayoutTests/platform/win/Skipped (87677 => 87678)


--- trunk/LayoutTests/platform/win/Skipped	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/LayoutTests/platform/win/Skipped	2011-05-30 07:22:21 UTC (rev 87678)
@@ -1007,7 +1007,6 @@
 fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
 http/tests/misc/link-rel-prefetch-and-subresource.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html

Modified: trunk/Source/WebCore/ChangeLog (87677 => 87678)


--- trunk/Source/WebCore/ChangeLog	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/Source/WebCore/ChangeLog	2011-05-30 07:22:21 UTC (rev 87678)
@@ -1,3 +1,15 @@
+2011-05-30  Sheriff Bot  <webkit.review....@gmail.com>
+
+        Unreviewed, rolling out r87618.
+        http://trac.webkit.org/changeset/87618
+        https://bugs.webkit.org/show_bug.cgi?id=61720
+
+        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
+        abarth|gardener on #webkit).
+
+        * html/HTMLLinkElement.cpp:
+        (WebCore::HTMLLinkElement::process):
+
 2011-05-29  Yuta Kitamura  <yu...@chromium.org>
 
         Reviewed by Kent Tamura.

Modified: trunk/Source/WebCore/html/HTMLLinkElement.cpp (87677 => 87678)


--- trunk/Source/WebCore/html/HTMLLinkElement.cpp	2011-05-30 06:25:52 UTC (rev 87677)
+++ trunk/Source/WebCore/html/HTMLLinkElement.cpp	2011-05-30 07:22:21 UTC (rev 87678)
@@ -266,11 +266,6 @@
             type = CachedResource::LinkPrerender;
 
         ResourceRequest linkRequest(document()->completeURL(m_url));
-        
-        if (m_cachedLinkResource) {
-            m_cachedLinkResource->removeClient(this);
-            m_cachedLinkResource = 0;
-        }
         m_cachedLinkResource = document()->cachedResourceLoader()->requestLinkResource(type, linkRequest, priority);
         if (m_cachedLinkResource)
             m_cachedLinkResource->addClient(this);

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to