Title: [87942] trunk/Source/WebCore
- Revision
- 87942
- Author
- e...@google.com
- Date
- 2011-06-02 12:45:27 -0700 (Thu, 02 Jun 2011)
Log Message
2011-06-01 Adrienne Walker <e...@google.com>
Reviewed by Eric Seidel.
[chromium] LayerChromium should use a RefPtr for replica layer
https://bugs.webkit.org/show_bug.cgi?id=61898
Having this member variable be a raw pointer is brittle and assumes
that the GraphicsLayer tree keeps this in sync. There aren't any
known bugs caused by this, but it seems like good sense to do this.
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::replicaLayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (87941 => 87942)
--- trunk/Source/WebCore/ChangeLog 2011-06-02 19:38:49 UTC (rev 87941)
+++ trunk/Source/WebCore/ChangeLog 2011-06-02 19:45:27 UTC (rev 87942)
@@ -1,3 +1,17 @@
+2011-06-01 Adrienne Walker <e...@google.com>
+
+ Reviewed by Eric Seidel.
+
+ [chromium] LayerChromium should use a RefPtr for replica layer
+ https://bugs.webkit.org/show_bug.cgi?id=61898
+
+ Having this member variable be a raw pointer is brittle and assumes
+ that the GraphicsLayer tree keeps this in sync. There aren't any
+ known bugs caused by this, but it seems like good sense to do this.
+
+ * platform/graphics/chromium/LayerChromium.h:
+ (WebCore::LayerChromium::replicaLayer):
+
2011-06-02 Ryosuke Niwa <rn...@webkit.org>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (87941 => 87942)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-06-02 19:38:49 UTC (rev 87941)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-06-02 19:45:27 UTC (rev 87942)
@@ -148,7 +148,7 @@
void setOwner(GraphicsLayerChromium* owner) { m_owner = owner; }
void setReplicaLayer(LayerChromium* layer) { m_replicaLayer = layer; }
- LayerChromium* replicaLayer() { return m_replicaLayer; }
+ LayerChromium* replicaLayer() { return m_replicaLayer.get(); }
// These methods typically need to be overwritten by derived classes.
virtual bool drawsContent() const { return false; }
@@ -271,7 +271,7 @@
FloatRect m_frame;
// Replica layer used for reflections.
- LayerChromium* m_replicaLayer;
+ RefPtr<LayerChromium> m_replicaLayer;
String m_name;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
