Title: [89371] trunk/Source/_javascript_Core
- Revision
- 89371
- Author
- oli...@apple.com
- Date
- 2011-06-21 12:30:31 -0700 (Tue, 21 Jun 2011)
Log Message
2011-06-21 Oliver Hunt <oli...@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=63052
Release mode only failure, the stack overflow guards were getting there error
handling inlined, so that they were essentially causing their own demise.
* parser/JSParser.cpp:
(JSC::JSParser::updateErrorMessage):
(JSC::JSParser::updateErrorWithNameAndMessage):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (89370 => 89371)
--- trunk/Source/_javascript_Core/ChangeLog 2011-06-21 19:29:58 UTC (rev 89370)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-06-21 19:30:31 UTC (rev 89371)
@@ -1,3 +1,17 @@
+2011-06-21 Oliver Hunt <oli...@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
+ https://bugs.webkit.org/show_bug.cgi?id=63052
+
+ Release mode only failure, the stack overflow guards were getting there error
+ handling inlined, so that they were essentially causing their own demise.
+
+ * parser/JSParser.cpp:
+ (JSC::JSParser::updateErrorMessage):
+ (JSC::JSParser::updateErrorWithNameAndMessage):
+
2011-06-20 Kenneth Russell <k...@google.com>
Unreviewed.
Modified: trunk/Source/_javascript_Core/parser/JSParser.cpp (89370 => 89371)
--- trunk/Source/_javascript_Core/parser/JSParser.cpp 2011-06-21 19:29:58 UTC (rev 89370)
+++ trunk/Source/_javascript_Core/parser/JSParser.cpp 2011-06-21 19:30:31 UTC (rev 89371)
@@ -391,7 +391,7 @@
}
}
- ALWAYS_INLINE void updateErrorMessage()
+ NEVER_INLINE void updateErrorMessage()
{
m_error = true;
const char* name = getTokenName(m_token.m_type);
@@ -401,7 +401,7 @@
m_errorMessage = UString(String::format("Unexpected token '%s'", name).impl());
}
- ALWAYS_INLINE void updateErrorMessage(JSTokenType expectedToken)
+ NEVER_INLINE void updateErrorMessage(JSTokenType expectedToken)
{
m_error = true;
const char* name = getTokenName(expectedToken);
@@ -411,7 +411,7 @@
m_errorMessage = UString(String::format("Expected token '%s'", name).impl());
}
- ALWAYS_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, UString name, const char* afterMsg)
+ NEVER_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, UString name, const char* afterMsg)
{
m_error = true;
String prefix(beforeMsg);
@@ -423,7 +423,7 @@
m_errorMessage = prefix.impl();
}
- ALWAYS_INLINE void updateErrorMessage(const char* msg)
+ NEVER_INLINE void updateErrorMessage(const char* msg)
{
m_error = true;
m_errorMessage = UString(msg);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
