Title: [89378] trunk
- Revision
- 89378
- Author
- commit-qu...@webkit.org
- Date
- 2011-06-21 14:07:00 -0700 (Tue, 21 Jun 2011)
Log Message
2011-06-21 Mark Pilgrim <pilg...@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065
* storage/indexeddb/database-name-undefined-expected.txt:
* storage/indexeddb/database-name-undefined.html:
2011-06-21 Mark Pilgrim <pilg...@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065
* storage/IDBFactory.idl: remove LegacyDefaultOptionalArguments flag
and fix function argument flags
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (89377 => 89378)
--- trunk/LayoutTests/ChangeLog 2011-06-21 20:57:35 UTC (rev 89377)
+++ trunk/LayoutTests/ChangeLog 2011-06-21 21:07:00 UTC (rev 89378)
@@ -2,6 +2,16 @@
Reviewed by Tony Chang.
+ IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
+ https://bugs.webkit.org/show_bug.cgi?id=63065
+
+ * storage/indexeddb/database-name-undefined-expected.txt:
+ * storage/indexeddb/database-name-undefined.html:
+
+2011-06-21 Mark Pilgrim <pilg...@chromium.org>
+
+ Reviewed by Tony Chang.
+
IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079
Modified: trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt (89377 => 89378)
--- trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt 2011-06-21 20:57:35 UTC (rev 89377)
+++ trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt 2011-06-21 21:07:00 UTC (rev 89378)
@@ -11,9 +11,8 @@
PASS IDBCursor == null is false
IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
PASS IDBKeyRange == null is false
-Expecting exception from indexedDB.open();
-PASS Exception was thrown.
-PASS code is IDBDatabaseException.NON_TRANSIENT_ERR
+PASS indexedDB.open(); threw exception TypeError: Not enough arguments.
+PASS indexedDB.open(null); threw exception Error: NON_TRANSIENT_ERR: DOM IDBDatabase Exception 2.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/database-name-undefined.html (89377 => 89378)
--- trunk/LayoutTests/storage/indexeddb/database-name-undefined.html 2011-06-21 20:57:35 UTC (rev 89377)
+++ trunk/LayoutTests/storage/indexeddb/database-name-undefined.html 2011-06-21 21:07:00 UTC (rev 89378)
@@ -26,7 +26,8 @@
IDBKeyRange = evalAndLog("IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;");
shouldBeFalse("IDBKeyRange == null");
- evalAndExpectException("indexedDB.open();", "IDBDatabaseException.NON_TRANSIENT_ERR");
+ shouldThrow("indexedDB.open();");
+ shouldThrow("indexedDB.open(null);");
done();
}
Modified: trunk/Source/WebCore/ChangeLog (89377 => 89378)
--- trunk/Source/WebCore/ChangeLog 2011-06-21 20:57:35 UTC (rev 89377)
+++ trunk/Source/WebCore/ChangeLog 2011-06-21 21:07:00 UTC (rev 89378)
@@ -2,6 +2,16 @@
Reviewed by Tony Chang.
+ IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
+ https://bugs.webkit.org/show_bug.cgi?id=63065
+
+ * storage/IDBFactory.idl: remove LegacyDefaultOptionalArguments flag
+ and fix function argument flags
+
+2011-06-21 Mark Pilgrim <pilg...@chromium.org>
+
+ Reviewed by Tony Chang.
+
IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079
Modified: trunk/Source/WebCore/storage/IDBFactory.idl (89377 => 89378)
--- trunk/Source/WebCore/storage/IDBFactory.idl 2011-06-21 20:57:35 UTC (rev 89377)
+++ trunk/Source/WebCore/storage/IDBFactory.idl 2011-06-21 21:07:00 UTC (rev 89378)
@@ -26,10 +26,9 @@
module storage {
interface [
- LegacyDefaultOptionalArguments,
Conditional=INDEXED_DATABASE
] IDBFactory {
- [CallWith=ScriptExecutionContext] IDBRequest open(in [ConvertUndefinedOrNullToNullString] DOMString name)
+ [CallWith=ScriptExecutionContext] IDBRequest open(in [ConvertNullToNullString] DOMString name)
raises (IDBDatabaseException);
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
