Modified: trunk/Tools/ChangeLog (90863 => 90864)
--- trunk/Tools/ChangeLog 2011-07-12 22:34:04 UTC (rev 90863)
+++ trunk/Tools/ChangeLog 2011-07-12 22:35:28 UTC (rev 90864)
@@ -1,3 +1,19 @@
+2011-07-12 Adam Barth <aba...@webkit.org>
+
+ cr-linux-ews should run pixel tests
+ https://bugs.webkit.org/show_bug.cgi?id=64394
+
+ Reviewed by Ojan Vafai.
+
+ This patch enabled pixel test on the cr-linux-ews. Running a quick
+ test on the bots, it looks like we have five pixel failures, related to
+ some missing fonts. I've also made the bots skip failing tests to
+ avoid uploading huge zip files to bugs.webkit.org (with all the exected
+ IMAGE failures).
+
+ * Scripts/webkitpy/common/config/ports.py:
+ * Scripts/webkitpy/common/config/ports_unittest.py:
+
2011-07-12 Joseph Pecoraro <joep...@webkit.org>
ApplicationCache update should not immediately fail when reaching per-origin quota
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (90863 => 90864)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-07-12 22:34:04 UTC (rev 90863)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-07-12 22:35:28 UTC (rev 90864)
@@ -245,7 +245,7 @@
def run_webkit_tests_command(cls):
command = cls.script_shell_command("new-run-webkit-tests")
command.append("--chromium")
- command.append("--no-pixel-tests")
+ command.append("--skip-failing-tests")
return command
@classmethod
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py (90863 => 90864)
--- trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2011-07-12 22:34:04 UTC (rev 90863)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2011-07-12 22:35:28 UTC (rev 90864)
@@ -64,13 +64,13 @@
def test_chromium_port(self):
self.assertEquals(ChromiumPort.name(), "Chromium")
self.assertEquals(ChromiumPort.flag(), "--port=chromium")
- self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("new-run-webkit-tests"), "--chromium", "--no-pixel-tests"])
+ self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("new-run-webkit-tests"), "--chromium", "--skip-failing-tests"])
self.assertEquals(ChromiumPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--chromium", "--update-chromium"])
self.assertEquals(ChromiumPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--chromium", "--update-chromium"])
self.assertEquals(ChromiumPort.update_webkit_command(), [WebKitPort.script_path("update-webkit"), "--chromium"])
def test_chromium_xvfb_port(self):
- self.assertEquals(ChromiumXVFBPort.run_webkit_tests_command(), ['xvfb-run', 'Tools/Scripts/new-run-webkit-tests', '--chromium', '--no-pixel-tests', '--results-directory=/tmp/layout-test-results', '--skip-failing-tests', '--print=actual,config,expected,misc,slowest,unexpected,unexpected-results'])
+ self.assertEquals(ChromiumXVFBPort.run_webkit_tests_command(), ['xvfb-run', 'Tools/Scripts/new-run-webkit-tests', '--chromium', '--skip-failing-tests', '--results-directory=/tmp/layout-test-results', '--skip-failing-tests', '--print=actual,config,expected,misc,slowest,unexpected,unexpected-results'])
if __name__ == '__main__':
unittest.main()
