Title: [90918] trunk/Tools
- Revision
- 90918
- Author
- x...@webkit.org
- Date
- 2011-07-13 07:52:07 -0700 (Wed, 13 Jul 2011)
Log Message
2011-07-13 Xan Lopez <xlo...@igalia.com>
[GTK] Do not grab focus too early in DRT.
Reviewed by Gustavo Noronha.
It causes a layout to happen and a progress signal to be emitted
since r90900, but at this point we don't have a
LayoutTestController object and we'll eventually crash. Since we
already grab focus at the beginning of runTest() this is
redundant, so get rid of it to fix the crash.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(main): remove call to grab_focus
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90917 => 90918)
--- trunk/Tools/ChangeLog 2011-07-13 14:31:45 UTC (rev 90917)
+++ trunk/Tools/ChangeLog 2011-07-13 14:52:07 UTC (rev 90918)
@@ -1,3 +1,18 @@
+2011-07-13 Xan Lopez <xlo...@igalia.com>
+
+ [GTK] Do not grab focus too early in DRT.
+
+ Reviewed by Gustavo Noronha.
+
+ It causes a layout to happen and a progress signal to be emitted
+ since r90900, but at this point we don't have a
+ LayoutTestController object and we'll eventually crash. Since we
+ already grab focus at the beginning of runTest() this is
+ redundant, so get rid of it to fix the crash.
+
+ * DumpRenderTree/gtk/DumpRenderTree.cpp:
+ (main): remove call to grab_focus
+
2011-07-13 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r90893 and r90894.
Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (90917 => 90918)
--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2011-07-13 14:31:45 UTC (rev 90917)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2011-07-13 14:52:07 UTC (rev 90918)
@@ -1172,7 +1172,6 @@
gtk_container_add(GTK_CONTAINER(container), GTK_WIDGET(webView));
gtk_widget_realize(GTK_WIDGET(webView));
gtk_widget_show_all(container);
- gtk_widget_grab_focus(GTK_WIDGET(webView));
mainFrame = webkit_web_view_get_main_frame(webView);
setDefaultsToConsistentStateValuesForTesting();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
