Title: [93178] trunk/Tools
Revision
93178
Author
aba...@webkit.org
Date
2011-08-16 16:51:37 -0700 (Tue, 16 Aug 2011)

Log Message

Change webkit-patch analyze-baselines to print in a more unix-friendly way
https://bugs.webkit.org/show_bug.cgi?id=66349

Reviewed by James Robinson.

As requested by jamesr.

* Scripts/webkitpy/tool/commands/rebaseline.py:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (93177 => 93178)


--- trunk/Tools/ChangeLog	2011-08-16 23:30:13 UTC (rev 93177)
+++ trunk/Tools/ChangeLog	2011-08-16 23:51:37 UTC (rev 93178)
@@ -1,3 +1,14 @@
+2011-08-16  Adam Barth  <aba...@webkit.org>
+
+        Change webkit-patch analyze-baselines to print in a more unix-friendly way
+        https://bugs.webkit.org/show_bug.cgi?id=66349
+
+        Reviewed by James Robinson.
+
+        As requested by jamesr.
+
+        * Scripts/webkitpy/tool/commands/rebaseline.py:
+
 2011-08-16  Eric Seidel  <e...@webkit.org>
 
         REGRESSION(92717): WinPort needs to parse version information from port_name

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (93177 => 93178)


--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:30:13 UTC (rev 93177)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:51:37 UTC (rev 93178)
@@ -30,7 +30,6 @@
 import re
 import shutil
 import urllib
-import pprint
 
 import webkitpy.common.config.urls as config_urls
 from webkitpy.common.checkout.baselineoptimizer import BaselineOptimizer
@@ -128,17 +127,21 @@
 
 class AnalyzeBaselines(AbstractDeclarativeCommand):
     name = "analyze-baselines"
-    help_text = "Analyzes the baselines for the given tests and displays which ones have the same hash."
+    help_text = "Analyzes the baselines for the given tests and prints results that are identical."
     argument_names = "TEST_NAMES"
 
+    def _print(self, baseline_name, directories_by_result):
+        for result, directories in directories_by_result.items():
+            if len(directories) <= 1:
+                continue
+            results_names = [self._tool.filesystem.join(directory, baseline_name) for directory in directories]
+            print ' '.join(results_names)
+
     def _analyze_baseline(self, test_name):
         for suffix in _baseline_suffix_list:
             baseline_name = _baseline_name(self._tool.filesystem, test_name, suffix)
             directories_by_result = self._baseline_optimizer.directories_by_result(baseline_name)
-            if directories_by_result:
-                print '== ', baseline_name, ' =='
-                pprint.pprint(directories_by_result)
-                print
+            self._print(baseline_name, directories_by_result)
 
     def _to_test_name(self, file_name): 
         return self._tool.filesystem.relpath(file_name, self._port.layout_tests_dir())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to