Title: [93737] trunk
- Revision
- 93737
- Author
- jam...@google.com
- Date
- 2011-08-24 14:27:25 -0700 (Wed, 24 Aug 2011)
Log Message
Some compositing LayoutTests flakily crashing on Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=66740
Reviewed by Adam Barth.
Tools:
Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
chromium configuration.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_Destroy):
LayoutTests:
Remove = CRASH expectations for plugin tests that should no longer crash.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (93736 => 93737)
--- trunk/LayoutTests/ChangeLog 2011-08-24 21:25:07 UTC (rev 93736)
+++ trunk/LayoutTests/ChangeLog 2011-08-24 21:27:25 UTC (rev 93737)
@@ -1,3 +1,14 @@
+2011-08-24 James Robinson <jam...@chromium.org>
+
+ Some compositing LayoutTests flakily crashing on Mac 10.6
+ https://bugs.webkit.org/show_bug.cgi?id=66740
+
+ Reviewed by Adam Barth.
+
+ Remove = CRASH expectations for plugin tests that should no longer crash.
+
+ * platform/chromium/test_expectations.txt:
+
2011-08-24 Peter Kasting <pkast...@google.com>
[chromium] More test expectation updates.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93736 => 93737)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-24 21:25:07 UTC (rev 93736)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-24 21:27:25 UTC (rev 93737)
@@ -2629,10 +2629,8 @@
// Chromium does not support PDF or plugin content in layers right now.
BUGWK47925 LINUX WIN GPU : compositing/plugins/composited-plugin.html = IMAGE+TEXT
-BUGWK47925 MAC GPU : compositing/plugins/composited-plugin.html = CRASH
-BUGWK47925 MAC GPU : compositing/plugins/small-to-large-composited-plugin.html = CRASH
-BUGWK47925 MAC GPU : compositing/plugins/1x1-composited-plugin.html = CRASH
-BUGWK47925 MAC GPU : compositing/plugins/large-to-small-composited-plugin.html = CRASH
+BUGWK47925 MAC GPU : compositing/plugins/composited-plugin.html = IMAGE+TEXT
+BUGWK47925 MAC GPU : compositing/plugins/small-to-large-composited-plugin.html = TEXT
BUGWK47949 LINUX WIN GPU : compositing/reflections/nested-reflection-anchor-point.html = IMAGE+TEXT
BUGWK47949 MAC GPU : compositing/reflections/nested-reflection-anchor-point.html = IMAGE
@@ -2665,9 +2663,7 @@
BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT
-BUGWK54051 MAC CPU : plugins/invalidate_rect.html = TEXT
-BUGWK54051 LEOPARD GPU : plugins/invalidate_rect.html = TEXT
-BUGWK54051 SNOWLEOPARD GPU : plugins/invalidate_rect.html = TEXT CRASH
+BUGWK54051 MAC : plugins/invalidate_rect.html = TEXT
BUGWK54051 MAC : plugins/windowless_plugin_paint_test.html = TIMEOUT
// Snow Leopard-only failures (generally just need updated pixel results)
@@ -3646,24 +3642,6 @@
BUGWK66738 SLOW WIN RELEASE : http/tests/inspector/network/download.html = PASS
-BUGWK66740 SNOWLEOPARD GPU : compositing/geometry/ancestor-overflow-change.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/geometry/fixed-in-composited.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/geometry/limit-layer-bounds-transformed-overflow.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/iframes/connect-compositing-iframe-delayed.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/iframes/connect-compositing-iframe3.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/iframes/iframe-resize.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/iframes/become-composited-nested-iframes.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/iframes/overlapped-iframe.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/iframes/overlapped-nested-iframes.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/iframes/repaint-after-losing-scrollbars.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/overflow/fixed-position-ancestor-clip.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : compositing/scaling/tiled-layer-recursion.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD DEBUG : fast/ruby/text-emphasis.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD GPU : platform/chromium/compositing/layout-width-change.html = PASS CRASH
-BUGWK66740 SNOWLEOPARD DEBUG : svg/animations/svginteger-animation-1.html = PASS CRASH TEXT
-
BUGWK66795 LINUX MAC SLOW : fast/js/reentrant-caching.html = PASS
BUGWK66873 SLOW WIN RELEASE : http/tests/loading/redirect-methods.html = PASS TEXT
Modified: trunk/Tools/ChangeLog (93736 => 93737)
--- trunk/Tools/ChangeLog 2011-08-24 21:25:07 UTC (rev 93736)
+++ trunk/Tools/ChangeLog 2011-08-24 21:27:25 UTC (rev 93737)
@@ -1,3 +1,17 @@
+2011-08-24 James Robinson <jam...@chromium.org>
+
+ Some compositing LayoutTests flakily crashing on Mac 10.6
+ https://bugs.webkit.org/show_bug.cgi?id=66740
+
+ Reviewed by Adam Barth.
+
+ Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
+ example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
+ chromium configuration.
+
+ * DumpRenderTree/TestNetscapePlugIn/main.cpp:
+ (NPP_Destroy):
+
2011-08-24 Anton D'Auria <adau...@apple.com>
No review necessary.
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp (93736 => 93737)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp 2011-08-24 21:25:07 UTC (rev 93736)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp 2011-08-24 21:27:25 UTC (rev 93737)
@@ -324,7 +324,8 @@
CFRelease(obj->coreAnimationLayer);
#endif
- obj->pluginTest->NPP_Destroy(save);
+ if (obj->pluginTest)
+ obj->pluginTest->NPP_Destroy(save);
browser->releaseobject(&obj->header);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
