Title: [94410] trunk/Source/WebCore
- Revision
- 94410
- Author
- vse...@chromium.org
- Date
- 2011-09-02 04:49:36 -0700 (Fri, 02 Sep 2011)
Log Message
Web Inspector: Make it more clear when requests are loaded from cache on network panel.
https://bugs.webkit.org/show_bug.cgi?id=67396
Reviewed by Pavel Feldman.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
* inspector/front-end/networkPanel.css:
(.resource-headers-view .outline-disclosure li .status-from-cache):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94409 => 94410)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 11:49:36 UTC (rev 94410)
@@ -1,5 +1,19 @@
2011-09-02 Vsevolod Vlasov <vse...@chromium.org>
+ Web Inspector: Make it more clear when requests are loaded from cache on network panel.
+ https://bugs.webkit.org/show_bug.cgi?id=67396
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
+ * inspector/front-end/ResourceHeadersView.js:
+ (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
+ * inspector/front-end/networkPanel.css:
+ (.resource-headers-view .outline-disclosure li .status-from-cache):
+
+2011-09-02 Vsevolod Vlasov <vse...@chromium.org>
+
Web Inspector: Should remove resource highlight on sort/filter in network panel.
https://bugs.webkit.org/show_bug.cgi?id=67411
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (94409 => 94410)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:49:36 UTC (rev 94410)
@@ -1962,11 +1962,12 @@
if (this._resource.statusCode) {
this._statusCell.appendChild(document.createTextNode(this._resource.statusCode));
- this._statusCell.removeStyleClass("network-dim-cell");
this._appendSubtitle(this._statusCell, this._resource.statusText);
this._statusCell.title = this._resource.statusCode + " " + this._resource.statusText;
if (this._resource.statusCode >= 400)
this.element.addStyleClass("network-error-row");
+ if (this._resource.cached)
+ this._statusCell.addStyleClass("network-dim-cell");
} else {
if (!this._resource.isHttpFamily() && this._resource.finished)
this._statusCell.setTextAndTitle(WebInspector.UIString("Success"));
Modified: trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js (94409 => 94410)
--- trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js 2011-09-02 11:49:36 UTC (rev 94410)
@@ -304,8 +304,12 @@
requestMethodElement.titleHTML = "<div class=\"header-name\">" + WebInspector.UIString("Request Method") + ":</div>" +
"<div class=\"header-value source-code\">" + this._resource.requestMethod + "</div>";
+ var fromCacheSpan = "";
+ if (this._resource.cached)
+ fromCacheSpan = " " + "<span class=\"status-from-cache\">" + WebInspector.UIString("(from cache)").escapeHTML() + "</span>";
+
statusCodeElement.titleHTML = "<div class=\"header-name\">" + WebInspector.UIString("Status Code") + ":</div>" +
- statusCodeImage + "<div class=\"header-value source-code\">" + statusTextEscaped + "</div>";
+ statusCodeImage + "<div class=\"header-value source-code\">" + statusTextEscaped + fromCacheSpan + "</div>";
}
},
Modified: trunk/Source/WebCore/inspector/front-end/networkPanel.css (94409 => 94410)
--- trunk/Source/WebCore/inspector/front-end/networkPanel.css 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/inspector/front-end/networkPanel.css 2011-09-02 11:49:36 UTC (rev 94410)
@@ -135,6 +135,10 @@
display: none;
}
+.resource-headers-view .outline-disclosure li .status-from-cache {
+ color: gray;
+}
+
.resource-headers-view .outline-disclosure li.expanded .header-toggle {
display: inline;
margin-left: 30px;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
