Title: [95037] trunk/Source/WebKit/chromium
Revision
95037
Author
simon...@chromium.org
Date
2011-09-13 12:18:27 -0700 (Tue, 13 Sep 2011)

Log Message

2011-09-13  James Simonsen  <simon...@chromium.org>

        [Chromium] Ref protect element in FrameLoaderClientImpl::createPlugin
        https://bugs.webkit.org/show_bug.cgi?id=68014

        Reviewed by Nate Chapin.

        Test: plugins/destroy-during-npp-new.htm under valgrind

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::createPlugin):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95036 => 95037)


--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-13 18:33:51 UTC (rev 95036)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-13 19:18:27 UTC (rev 95037)
@@ -1,3 +1,15 @@
+2011-09-13  James Simonsen  <simon...@chromium.org>
+
+        [Chromium] Ref protect element in FrameLoaderClientImpl::createPlugin
+        https://bugs.webkit.org/show_bug.cgi?id=68014
+
+        Reviewed by Nate Chapin.
+
+        Test: plugins/destroy-during-npp-new.htm under valgrind
+
+        * src/FrameLoaderClientImpl.cpp:
+        (WebKit::FrameLoaderClientImpl::createPlugin):
+
 2011-09-13  Sheriff Bot  <webkit.review....@gmail.com>
 
         Unreviewed.  Rolled DEPS.

Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp (95036 => 95037)


--- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp	2011-09-13 18:33:51 UTC (rev 95036)
+++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp	2011-09-13 19:18:27 UTC (rev 95037)
@@ -1486,6 +1486,8 @@
     if (!m_webFrame->client())
         return 0;
 
+    RefPtr<HTMLPlugInElement> protect(element);
+
     WebPluginParams params;
     params.url = ""
     params.mimeType = mimeType;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to