Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js (95067 => 95068)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2011-09-14 01:21:52 UTC (rev 95067)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2011-09-14 01:23:14 UTC (rev 95068)
@@ -30,7 +30,7 @@
var kBuildingResult = 'BUILDING';
-ui.failures.Configuration = base.extends('div', {
+ui.failures.Configuration = base.extends('a', {
init: function(configuration)
{
if (configuration.is64bit)
@@ -38,6 +38,7 @@
if (configuration.version)
this._addSpan('version', configuration.version);
this._configuration = configuration;
+ this.target = '_blank';
},
_addSpan: function(className, text)
{
@@ -107,7 +108,7 @@
var cell = cellByBuildType(row, configuration);
if (cellContainsConfiguration(cell, configuration))
return;
- cell.appendChild(new ui.failures.Configuration(configuration));
+ cell.appendChild(new ui.failures.Configuration(configuration)).href = ""
}, this);
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js (95067 => 95068)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js 2011-09-14 01:21:52 UTC (rev 95067)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js 2011-09-14 01:23:14 UTC (rev 95068)
@@ -35,13 +35,13 @@
var configuration;
configuration = new ui.failures.Configuration({});
deepEqual(Object.getOwnPropertyNames(configuration.__proto__), ['init', 'equals', '_addSpan']);
- equal(configuration.outerHTML, '<div></div>');
+ equal(configuration.outerHTML, '<a target="_blank"></a>');
configuration = new ui.failures.Configuration({is64bit: true, version: 'lucid'});
- equal(configuration.outerHTML, '<div><span class="architecture">64-bit</span><span class="version">lucid</span></div>');
+ equal(configuration.outerHTML, '<a target="_blank"><span class="architecture">64-bit</span><span class="version">lucid</span></a>');
configuration = new ui.failures.Configuration({version: 'xp'});
- equal(configuration.outerHTML, '<div><span class="version">xp</span></div>');
+ equal(configuration.outerHTML, '<a target="_blank"><span class="version">xp</span></a>');
configuration._addSpan('foo', 'bar');
- equal(configuration.outerHTML, '<div><span class="version">xp</span><span class="foo">bar</span></div>');
+ equal(configuration.outerHTML, '<a target="_blank"><span class="version">xp</span><span class="foo">bar</span></a>');
ok(configuration.equals({version: 'xp'}));
ok(!configuration.equals({version: 'lucid',is64bit: true}));
});
@@ -84,7 +84,7 @@
'<tr class="TEXT">' +
'<td>TEXT</td>' +
'<td></td>' +
- '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
+ '<td><a target="_blank" href="" class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
'</tr>' +
'<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
'</tbody>' +
@@ -95,13 +95,13 @@
'<tbody>' +
'<tr class="IMAGE+TEXT">' +
'<td>IMAGE+TEXT</td>' +
- '<td><div><span class="version">leopard</span></div></td>' +
+ '<td><a target="_blank" href="" class="version">leopard</span></a></td>' +
'<td></td>' +
'</tr>' +
'<tr class="TEXT">' +
'<td>TEXT</td>' +
'<td></td>' +
- '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
+ '<td><a target="_blank" href="" class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
'</tr>' +
'<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
'</tbody>' +
@@ -112,13 +112,13 @@
'<tbody>' +
'<tr class="IMAGE+TEXT">' +
'<td>IMAGE+TEXT</td>' +
- '<td><div><span class="version">leopard</span></div></td>' +
+ '<td><a target="_blank" href="" class="version">leopard</span></a></td>' +
'<td></td>' +
'</tr>' +
'<tr class="TEXT">' +
'<td>TEXT</td>' +
'<td></td>' +
- '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
+ '<td><a target="_blank" href="" class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
'</tr>' +
'<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
'</tbody>' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (95067 => 95068)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-14 01:21:52 UTC (rev 95067)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-14 01:23:14 UTC (rev 95068)
@@ -217,7 +217,7 @@
'<tr class="TEXT">' +
'<td>TEXT</td>' +
'<td></td>' +
- '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
+ '<td><a target="_blank" href="" class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
'</tr>' +
'<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
'</tbody>' +
@@ -261,11 +261,11 @@
'<tr class="TEXT">' +
'<td>TEXT</td>' +
'<td></td>' +
- '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
+ '<td><a target="_blank" href="" class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
'</tr>' +
'<tr class="BUILDING" style="">' +
'<td>BUILDING</td>' +
- '<td><div><span class="version">leopard</span></div></td>' +
+ '<td><a target="_blank" href="" class="version">leopard</span></a></td>' +
'<td></td>' +
'</tr>' +
'</tbody>' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (95067 => 95068)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-14 01:21:52 UTC (rev 95067)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-14 01:23:14 UTC (rev 95068)
@@ -185,20 +185,22 @@
vertical-align: top;
}
- ol.notifications table.failures tbody td:nth-child(n+2)>div {
+ ol.notifications table.failures tbody td:nth-child(n+2)>a {
display: inline-block;
border: 1px solid Gray;
margin: 0 0 2px 0;
padding: 1px;
+ color: Black;
+ text-decoration: none;
}
- ol.notifications table.failures tbody td:nth-child(n+2)>div>span.version {
+ ol.notifications table.failures tbody td:nth-child(n+2)>a>span.version {
text-transform: uppercase;
background-color: #555;
color: White;
padding: 0 2px;
}
- ol.notifications table.failures tbody td:nth-child(n+2)>div>span.architecture {
+ ol.notifications table.failures tbody td:nth-child(n+2)>a>span.architecture {
padding: 0 3px 0 0;
}
Modified: trunk/Tools/ChangeLog (95067 => 95068)
--- trunk/Tools/ChangeLog 2011-09-14 01:21:52 UTC (rev 95067)
+++ trunk/Tools/ChangeLog 2011-09-14 01:23:14 UTC (rev 95068)
@@ -1,5 +1,21 @@
2011-09-13 Adam Barth <aba...@webkit.org>
+ FailureGrid in garden-o-matic should link to the builder's waterfall page
+ https://bugs.webkit.org/show_bug.cgi?id=68036
+
+ Reviewed by Dimitri Glazkov.
+
+ One of the users in the user study thought the configurations names in
+ the failure grid would link to the underlying bots. That makes sense,
+ so this patch adds the behavior.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
+
+2011-09-13 Adam Barth <aba...@webkit.org>
+
garden-o-matic should be able to mark failures as expected
https://bugs.webkit.org/show_bug.cgi?id=68027
