Diff
Modified: trunk/LayoutTests/ChangeLog (95330 => 95331)
--- trunk/LayoutTests/ChangeLog 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/LayoutTests/ChangeLog 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1,3 +1,17 @@
+2011-09-16 Geoffrey Garen <gga...@apple.com>
+
+ Removed undetectable style.filter.
+
+ Reviewed by Sam Weinig.
+
+ This feature was added in http://trac.webkit.org/changeset/15557 to
+ support housingmaps.com. But housingmaps.com no longer needs this hack,
+ we don't know of other websites that need it, and we don't know of
+ any other browsers that have implemented this feature.
+
+ * fast/dom/undetectable-style-filter-expected.txt: Removed.
+ * fast/dom/undetectable-style-filter.html: Removed.
+
2011-09-16 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r95317.
Deleted: trunk/LayoutTests/fast/dom/undetectable-style-filter-expected.txt (95330 => 95331)
--- trunk/LayoutTests/fast/dom/undetectable-style-filter-expected.txt 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/LayoutTests/fast/dom/undetectable-style-filter-expected.txt 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1,5 +0,0 @@
-This page tests whether the CSS 'filter' property is undetectable. If the test passes, you'll see a series of 'PASS' messages below.
-
-PASS: typeof document.body.style.filter should be undefined and is.
-PASS: document.body.style.filter ? true : false should be false and is.
-PASS: document.body.style.filter == undefined should be true and is.
Deleted: trunk/LayoutTests/fast/dom/undetectable-style-filter.html (95330 => 95331)
--- trunk/LayoutTests/fast/dom/undetectable-style-filter.html 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/LayoutTests/fast/dom/undetectable-style-filter.html 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1,48 +0,0 @@
-<html>
-<head>
-<script>
-function print(message, color)
-{
- var paragraph = document.createElement("div");
- paragraph.appendChild(document.createTextNode(message));
- paragraph.style.fontFamily = "monospace";
- if (color)
- paragraph.style.color = color;
- document.getElementById("console").appendChild(paragraph);
-}
-
-function shouldBe(a, b)
-{
- var evalA;
- try {
- evalA = eval(a);
- } catch(e) {
- evalA = e;
- }
-
- if (evalA == b)
- print("PASS: " + a + " should be " + b + " and is.", "green");
- else
- print("FAIL: " + a + " should be " + b + " but instead is " + evalA + ".", "red");
-}
-
-function test()
-{
- if (window.layoutTestController)
- layoutTestController.dumpAsText();
-
- shouldBe("typeof document.body.style.filter", "undefined");
- shouldBe("document.body.style.filter ? true : false", false);
- shouldBe("document.body.style.filter == undefined", true);
-}
-</script>
-</head>
-
-<body _onload_="test();">
-<p>This page tests whether the CSS 'filter' property is undetectable. If the test passes, you'll see a series of 'PASS' messages below.</p>
-<hr>
-
-<div id='console'></div>
-
-</body>
-</html>
Modified: trunk/Source/_javascript_Core/ChangeLog (95330 => 95331)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1,3 +1,21 @@
+2011-09-16 Geoffrey Garen <gga...@apple.com>
+
+ Removed undetectable style.filter.
+
+ Reviewed by Sam Weinig.
+
+ This feature was added in http://trac.webkit.org/changeset/15557 to
+ support housingmaps.com. But housingmaps.com no longer needs this hack,
+ we don't know of other websites that need it, and we don't know of
+ any other browsers that have implemented this feature.
+
+ * GNUmakefile.list.am:
+ * _javascript_Core.gypi:
+ * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj:
+ * _javascript_Core.xcodeproj/project.pbxproj:
+ * runtime/JSTypeInfo.h:
+ * runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
+
2011-09-15 Sam Weinig <s...@webkit.org>
Prepare JSTypes for more Object subtypes
Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (95330 => 95331)
--- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-09-16 23:02:43 UTC (rev 95331)
@@ -426,7 +426,6 @@
Source/_javascript_Core/runtime/StringConstructor.h \
Source/_javascript_Core/runtime/StringObject.cpp \
Source/_javascript_Core/runtime/StringObject.h \
- Source/_javascript_Core/runtime/StringObjectThatMasqueradesAsUndefined.h \
Source/_javascript_Core/runtime/StringPrototype.cpp \
Source/_javascript_Core/runtime/StringPrototype.h \
Source/_javascript_Core/runtime/StringRecursionChecker.cpp \
Modified: trunk/Source/_javascript_Core/_javascript_Core.gypi (95330 => 95331)
--- trunk/Source/_javascript_Core/_javascript_Core.gypi 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/_javascript_Core/_javascript_Core.gypi 2011-09-16 23:02:43 UTC (rev 95331)
@@ -116,7 +116,6 @@
'runtime/SmallStrings.h',
'runtime/StorageBarrier.h',
'runtime/StringObject.h',
- 'runtime/StringObjectThatMasqueradesAsUndefined.h',
'runtime/StringPrototype.h',
'runtime/Structure.h',
'runtime/StructureChain.h',
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj (95330 => 95331)
--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1146,10 +1146,6 @@
>
</File>
<File
- RelativePath="..\..\runtime\StringObjectThatMasqueradesAsUndefined.h"
- >
- </File>
- <File
RelativePath="..\..\runtime\StringPrototype.cpp"
>
</File>
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (95330 => 95331)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2011-09-16 23:02:43 UTC (rev 95331)
@@ -566,7 +566,6 @@
BC18C4660E16F5CD00B34460 /* StringConstructor.h in Headers */ = {isa = PBXBuildFile; fileRef = BC18C3C10E16EE3300B34460 /* StringConstructor.h */; };
BC18C4670E16F5CD00B34460 /* StringExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = E11D51750B2E798D0056C188 /* StringExtras.h */; settings = {ATTRIBUTES = (Private, ); }; };
BC18C4680E16F5CD00B34460 /* StringObject.h in Headers */ = {isa = PBXBuildFile; fileRef = BC18C3C30E16EE3300B34460 /* StringObject.h */; settings = {ATTRIBUTES = (Private, ); }; };
- BC18C4690E16F5CD00B34460 /* StringObjectThatMasqueradesAsUndefined.h in Headers */ = {isa = PBXBuildFile; fileRef = BC18C3C40E16EE3300B34460 /* StringObjectThatMasqueradesAsUndefined.h */; settings = {ATTRIBUTES = (Private, ); }; };
BC18C46A0E16F5CD00B34460 /* StringPrototype.h in Headers */ = {isa = PBXBuildFile; fileRef = BC18C3C60E16EE3300B34460 /* StringPrototype.h */; settings = {ATTRIBUTES = (Private, ); }; };
BC18C46B0E16F5CD00B34460 /* SymbolTable.h in Headers */ = {isa = PBXBuildFile; fileRef = 14A396A60CD2933100B5B4FF /* SymbolTable.h */; settings = {ATTRIBUTES = (Private, ); }; };
BC18C46C0E16F5CD00B34460 /* TCPackedCache.h in Headers */ = {isa = PBXBuildFile; fileRef = 5DA479650CFBCF56009328A0 /* TCPackedCache.h */; };
@@ -1267,7 +1266,6 @@
BC18C3C10E16EE3300B34460 /* StringConstructor.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringConstructor.h; sourceTree = "<group>"; };
BC18C3C20E16EE3300B34460 /* StringObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StringObject.cpp; sourceTree = "<group>"; };
BC18C3C30E16EE3300B34460 /* StringObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringObject.h; sourceTree = "<group>"; };
- BC18C3C40E16EE3300B34460 /* StringObjectThatMasqueradesAsUndefined.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringObjectThatMasqueradesAsUndefined.h; sourceTree = "<group>"; };
BC18C3C50E16EE3300B34460 /* StringPrototype.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StringPrototype.cpp; sourceTree = "<group>"; };
BC18C3C60E16EE3300B34460 /* StringPrototype.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringPrototype.h; sourceTree = "<group>"; };
BC18C5230E16FC8A00B34460 /* ArrayPrototype.lut.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ArrayPrototype.lut.h; sourceTree = "<group>"; };
@@ -2155,7 +2153,6 @@
BC18C3C10E16EE3300B34460 /* StringConstructor.h */,
BC18C3C20E16EE3300B34460 /* StringObject.cpp */,
BC18C3C30E16EE3300B34460 /* StringObject.h */,
- BC18C3C40E16EE3300B34460 /* StringObjectThatMasqueradesAsUndefined.h */,
BC18C3C50E16EE3300B34460 /* StringPrototype.cpp */,
BC18C3C60E16EE3300B34460 /* StringPrototype.h */,
93345A8712D838C400302BE3 /* StringRecursionChecker.cpp */,
@@ -2730,7 +2727,6 @@
86B99AE4117E578100DF5A90 /* StringImplBase.h in Headers */,
71DA9D82134F3F3D00B767E7 /* StringOperators.h in Headers */,
BC18C4680E16F5CD00B34460 /* StringObject.h in Headers */,
- BC18C4690E16F5CD00B34460 /* StringObjectThatMasqueradesAsUndefined.h in Headers */,
BC18C46A0E16F5CD00B34460 /* StringPrototype.h in Headers */,
BC18C5260E16FCA700B34460 /* StringPrototype.lut.h in Headers */,
142E313B134FF0A600AFADB5 /* Strong.h in Headers */,
Modified: trunk/Source/_javascript_Core/runtime/JSTypeInfo.h (95330 => 95331)
--- trunk/Source/_javascript_Core/runtime/JSTypeInfo.h 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/_javascript_Core/runtime/JSTypeInfo.h 2011-09-16 23:02:43 UTC (rev 95331)
@@ -34,7 +34,7 @@
namespace JSC {
- static const unsigned MasqueradesAsUndefined = 1; // WebCore uses MasqueradesAsUndefined to make document.all and style.filter undetectable.
+ static const unsigned MasqueradesAsUndefined = 1; // WebCore uses MasqueradesAsUndefined to make document.all undetectable.
static const unsigned ImplementsHasInstance = 1 << 1;
static const unsigned OverridesHasInstance = 1 << 2;
static const unsigned ImplementsDefaultHasInstance = 1 << 3;
Deleted: trunk/Source/_javascript_Core/runtime/StringObjectThatMasqueradesAsUndefined.h (95330 => 95331)
--- trunk/Source/_javascript_Core/runtime/StringObjectThatMasqueradesAsUndefined.h 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/_javascript_Core/runtime/StringObjectThatMasqueradesAsUndefined.h 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1,62 +0,0 @@
-/*
- * Copyright (C) 1999-2000 Harri Porten (por...@kde.org)
- * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- *
- */
-
-#ifndef StringObjectThatMasqueradesAsUndefined_h
-#define StringObjectThatMasqueradesAsUndefined_h
-
-#include "JSGlobalObject.h"
-#include "StringObject.h"
-#include "UString.h"
-
-namespace JSC {
-
- // WebCore uses this to make style.filter undetectable
- class StringObjectThatMasqueradesAsUndefined : public StringObject {
- public:
- typedef StringObject Base;
-
- static StringObjectThatMasqueradesAsUndefined* create(ExecState* exec, const UString& string)
- {
- JSString* newString = jsString(exec, string);
- Structure* structure = createStructure(exec->globalData(), exec->lexicalGlobalObject(), exec->lexicalGlobalObject()->stringPrototype());
- StringObjectThatMasqueradesAsUndefined* object = new (allocateCell<StringObjectThatMasqueradesAsUndefined>(*exec->heap())) StringObjectThatMasqueradesAsUndefined(exec, structure);
- object->finishCreation(exec->globalData(), newString);
- return object;
- }
-
- private:
- StringObjectThatMasqueradesAsUndefined(ExecState* exec, Structure* structure)
- : StringObject(exec->globalData(), structure)
- {
- }
-
- static Structure* createStructure(JSGlobalData& globalData, JSGlobalObject* globalObject, JSValue proto)
- {
- return Structure::create(globalData, globalObject, proto, TypeInfo(ObjectType, StructureFlags), &s_info);
- }
-
- static const unsigned StructureFlags = OverridesGetOwnPropertySlot | MasqueradesAsUndefined | OverridesGetPropertyNames | StringObject::StructureFlags;
-
- virtual bool toBoolean(ExecState*) const { return false; }
- };
-
-} // namespace JSC
-
-#endif // StringObjectThatMasqueradesAsUndefined_h
Modified: trunk/Source/WebCore/ChangeLog (95330 => 95331)
--- trunk/Source/WebCore/ChangeLog 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/WebCore/ChangeLog 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1,3 +1,19 @@
+2011-09-16 Geoffrey Garen <gga...@apple.com>
+
+ Removed undetectable style.filter.
+
+ Reviewed by Sam Weinig.
+
+ This feature was added in http://trac.webkit.org/changeset/15557 to
+ support housingmaps.com. But housingmaps.com no longer needs this hack,
+ we don't know of other websites that need it, and we don't know of
+ any other browsers that have implemented this feature.
+
+ * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
+ * WebCore.order:
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::nameGetter):
+
2011-09-16 Adam Barth <aba...@webkit.org>
Update JSC results to account for intrinsics change.
Deleted: trunk/Source/WebCore/ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h (95330 => 95331)
--- trunk/Source/WebCore/ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/WebCore/ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h 2011-09-16 23:02:43 UTC (rev 95331)
@@ -1,4 +0,0 @@
-#ifndef WebCore_FWD_StringObjectThatMasqueradesAsUndefined_h
-#define WebCore_FWD_StringObjectThatMasqueradesAsUndefined_h
-#include <_javascript_Core/StringObjectThatMasqueradesAsUndefined.h>
-#endif
Modified: trunk/Source/WebCore/WebCore.order (95330 => 95331)
--- trunk/Source/WebCore/WebCore.order 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/WebCore/WebCore.order 2011-09-16 23:02:43 UTC (rev 95331)
@@ -23455,9 +23455,6 @@
__ZN7WebCore8DOMTimer26adjustMinimumTimerIntervalEd
__ZN7WebCore20setJSHTMLDocumentAllEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE
__ZN7WebCore14JSHTMLDocument6setAllEPN3JSC9ExecStateENS1_7JSValueE
-__ZN3JSC38StringObjectThatMasqueradesAsUndefined6createEPNS_9ExecStateERKNS_7UStringE
-__ZNK3JSC38StringObjectThatMasqueradesAsUndefined9toBooleanEPNS_9ExecStateE
-__ZN3JSC38StringObjectThatMasqueradesAsUndefinedD1Ev
__ZN7WebCore16NavigationActionC1ERKNS_4KURLENS_14NavigationTypeE
__ZN7WebCore29jsDocumentFragmentConstructorEPN3JSC9ExecStateENS0_7JSValueERKNS0_10IdentifierE
__ZN7WebCore25jsNodeIteratorConstructorEPN3JSC9ExecStateENS0_7JSValueERKNS0_10IdentifierE
Modified: trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp (95330 => 95331)
--- trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp 2011-09-16 22:50:44 UTC (rev 95330)
+++ trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp 2011-09-16 23:02:43 UTC (rev 95331)
@@ -32,7 +32,6 @@
#include "JSCSSValue.h"
#include "JSNode.h"
#include "PlatformString.h"
-#include <runtime/StringObjectThatMasqueradesAsUndefined.h>
#include <runtime/StringPrototype.h>
#include <wtf/ASCIICType.h>
#include <wtf/text/AtomicString.h>
@@ -162,10 +161,6 @@
// If the property is a shorthand property (such as "padding"),
// it can only be accessed using getPropertyValue.
- // Make the SVG 'filter' attribute undetectable, to avoid confusion with the IE 'filter' attribute.
- if (propertyName == "filter")
- return StringObjectThatMasqueradesAsUndefined::create(exec, stringToUString(thisObj->impl()->getPropertyValue(prop)));
-
return jsString(exec, thisObj->impl()->getPropertyValue(prop));
}
