Title: [95640] trunk/Source/WebKit/chromium
Revision
95640
Author
commit-qu...@webkit.org
Date
2011-09-21 09:39:50 -0700 (Wed, 21 Sep 2011)

Log Message

[chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
https://bugs.webkit.org/show_bug.cgi?id=68351

Patch by chandra shekar vallala <chandra.vall...@gmail.com> on 2011-09-21
Reviewed by Darin Fisher.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::clearFocusedNode):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95639 => 95640)


--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-21 16:27:30 UTC (rev 95639)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-21 16:39:50 UTC (rev 95640)
@@ -1,3 +1,13 @@
+2011-09-21  chandra shekar vallala  <chandra.vall...@gmail.com>
+
+        [chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
+        https://bugs.webkit.org/show_bug.cgi?id=68351
+
+        Reviewed by Darin Fisher.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::clearFocusedNode):
+
 2011-09-20  Jay Civelli  <jcive...@chromium.org>
 
         This CL makes it possible to create a blob from Chromium.

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (95639 => 95640)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-09-21 16:27:30 UTC (rev 95639)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-09-21 16:39:50 UTC (rev 95640)
@@ -1802,9 +1802,9 @@
     // knows to remove selection from it. Otherwise, the text field is still
     // processing keyboard events even though focus has been moved to the page and
     // keystrokes get eaten as a result.
-    if (oldFocusedNode->hasTagName(HTMLNames::textareaTag)
-        || (oldFocusedNode->hasTagName(HTMLNames::inputTag)
-            && static_cast<HTMLInputElement*>(oldFocusedNode.get())->isTextField())) {
+    if (oldFocusedNode->isContentEditable()
+        || (oldFocusedNode->isElementNode()
+            && static_cast<Element*>(oldFocusedNode.get())->isTextFormControl())) {
         frame->selection()->clear();
     }
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to