Title: [96788] trunk/Source/WebCore
Revision
96788
Author
hara...@chromium.org
Date
2011-10-05 23:00:41 -0700 (Wed, 05 Oct 2011)

Log Message

Refactor IDL attributes about constructor
https://bugs.webkit.org/show_bug.cgi?id=69074

Reviewed by Adam Barth.

Currently, IDL attributes about constructor are confusing:

- [CustomConstructFunction] means that there is a custom constructor for JSC.
- [V8CustomConstructor] means that there is a custom constructor for V8.
- [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
- For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
- ObjC, CPP and GObject bindings do not support custom constructors.

This patch makes the following changes:

- Rename [CustomConstructFunction] to [JSCustomConstructor].
- [JSCustomConstructor] means that there is a custom constructor for JSC.
- [V8CustomConstructor] means that there is a custom constructor for V8.
- [CustomConstructor] means that there is a custom constructor for both JSC and V8.

No new tests. No change in behavior. Confirm that build succeeds.

* bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]
(GenerateHeader):
(GenerateAttributesHashTable):
(GenerateImplementation):
(GenerateConstructorDefinition):
* css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
* dom/CustomEvent.idl: Ditto.
* dom/ErrorEvent.idl: Ditto.
* dom/Event.idl: Ditto.
* dom/HashChangeEvent.idl: Ditto.
* dom/MessageChannel.idl: Ditto.
* dom/MessageEvent.idl: Ditto.
* dom/PageTransitionEvent.idl: Ditto.
* dom/PopStateEvent.idl: Ditto.
* dom/ProgressEvent.idl: Ditto.
* dom/WebKitAnimationEvent.idl: Ditto.
* html/DOMFormData.idl: Ditto.
* html/canvas/ArrayBuffer.idl: Ditto.
* html/canvas/DataView.idl: Ditto.
* html/canvas/Float32Array.idl: Ditto.
* html/canvas/Float64Array.idl: Ditto.
* html/canvas/Int16Array.idl: Ditto.
* html/canvas/Int32Array.idl: Ditto.
* html/canvas/Int8Array.idl: Ditto.
* html/canvas/Uint16Array.idl: Ditto.
* html/canvas/Uint32Array.idl: Ditto.
* html/canvas/Uint8Array.idl: Ditto.
* p2p/PeerConnection.idl: Ditto.
* page/EventSource.idl: Ditto.
* page/WebKitPoint.idl: Ditto.
* webaudio/AudioContext.idl: Ditto.
* websockets/CloseEvent.idl: Ditto.
* websockets/WebSocket.idl: Ditto.
* workers/SharedWorker.idl: Ditto.
* workers/Worker.idl: Ditto.
* xml/XMLHttpRequest.idl: Ditto.
* xml/XSLTProcessor.idl: Ditto.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (96787 => 96788)


--- trunk/Source/WebCore/ChangeLog	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/ChangeLog	2011-10-06 06:00:41 UTC (rev 96788)
@@ -1,3 +1,65 @@
+2011-10-05  Kentaro Hara  <hara...@chromium.org>
+
+        Refactor IDL attributes about constructor
+        https://bugs.webkit.org/show_bug.cgi?id=69074
+
+        Reviewed by Adam Barth.
+
+        Currently, IDL attributes about constructor are confusing:
+
+        - [CustomConstructFunction] means that there is a custom constructor for JSC.
+        - [V8CustomConstructor] means that there is a custom constructor for V8.
+        - [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
+        - For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
+        - ObjC, CPP and GObject bindings do not support custom constructors.
+
+        This patch makes the following changes:
+
+        - Rename [CustomConstructFunction] to [JSCustomConstructor].
+        - [JSCustomConstructor] means that there is a custom constructor for JSC.
+        - [V8CustomConstructor] means that there is a custom constructor for V8.
+        - [CustomConstructor] means that there is a custom constructor for both JSC and V8.
+
+        No new tests. No change in behavior. Confirm that build succeeds.
+
+        * bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]
+        (GenerateHeader):
+        (GenerateAttributesHashTable):
+        (GenerateImplementation):
+        (GenerateConstructorDefinition):
+        * css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
+        * dom/CustomEvent.idl: Ditto.
+        * dom/ErrorEvent.idl: Ditto.
+        * dom/Event.idl: Ditto.
+        * dom/HashChangeEvent.idl: Ditto.
+        * dom/MessageChannel.idl: Ditto.
+        * dom/MessageEvent.idl: Ditto.
+        * dom/PageTransitionEvent.idl: Ditto.
+        * dom/PopStateEvent.idl: Ditto.
+        * dom/ProgressEvent.idl: Ditto.
+        * dom/WebKitAnimationEvent.idl: Ditto.
+        * html/DOMFormData.idl: Ditto.
+        * html/canvas/ArrayBuffer.idl: Ditto.
+        * html/canvas/DataView.idl: Ditto.
+        * html/canvas/Float32Array.idl: Ditto.
+        * html/canvas/Float64Array.idl: Ditto.
+        * html/canvas/Int16Array.idl: Ditto.
+        * html/canvas/Int32Array.idl: Ditto.
+        * html/canvas/Int8Array.idl: Ditto.
+        * html/canvas/Uint16Array.idl: Ditto.
+        * html/canvas/Uint32Array.idl: Ditto.
+        * html/canvas/Uint8Array.idl: Ditto.
+        * p2p/PeerConnection.idl: Ditto.
+        * page/EventSource.idl: Ditto.
+        * page/WebKitPoint.idl: Ditto.
+        * webaudio/AudioContext.idl: Ditto.
+        * websockets/CloseEvent.idl: Ditto.
+        * websockets/WebSocket.idl: Ditto.
+        * workers/SharedWorker.idl: Ditto.
+        * workers/Worker.idl: Ditto.
+        * xml/XMLHttpRequest.idl: Ditto.
+        * xml/XSLTProcessor.idl: Ditto.
+
 2011-10-03  Andy Estes  <aes...@apple.com>
 
         Add the option to suppress rendering until the document's load event fires.

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (96787 => 96788)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-10-06 06:00:41 UTC (rev 96788)
@@ -759,8 +759,7 @@
     $implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"DelegatingPutFunction"});
 
     my $hasGetter = $numAttributes > 0 
-                 || !($dataNode->extendedAttributes->{"OmitConstructor"}
-                 || $dataNode->extendedAttributes->{"CustomConstructor"})
+                 || !$dataNode->extendedAttributes->{"OmitConstructor"}
                  || $dataNode->extendedAttributes->{"HasIndexGetter"}
                  || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}
                  || $dataNode->extendedAttributes->{"HasNumericIndexGetter"}
@@ -856,7 +855,7 @@
     }
 
     # Constructor object getter
-    push(@headerContent, "    static JSC::JSValue getConstructor(JSC::ExecState*, JSC::JSGlobalObject*);\n") if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"}));
+    push(@headerContent, "    static JSC::JSValue getConstructor(JSC::ExecState*, JSC::JSGlobalObject*);\n") if !$dataNode->extendedAttributes->{"OmitConstructor"};
 
     my $numCustomFunctions = 0;
     my $numCustomAttributes = 0;
@@ -1071,7 +1070,7 @@
     push(@headerContent, "};\n\n");
 
     # Conditionally emit the constructor object's declaration
-    if ($dataNode->extendedAttributes->{"CustomConstructFunction"}) {
+    if ($dataNode->extendedAttributes->{"JSCustomConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"}) {
         GenerateConstructorDeclaration(\@headerContent, $className, $dataNode);
     }
 
@@ -1085,7 +1084,7 @@
         }
     }
 
-    if ($numAttributes > 0 || !($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"})) {
+    if ($numAttributes > 0 || !$dataNode->extendedAttributes->{"OmitConstructor"}) {
         push(@headerContent,"// Attributes\n\n");
         foreach my $attribute (@{$dataNode->attributes}) {
             my $getter = "js" . $interfaceName . $codeGenerator->WK_ucfirst($attribute->signature->name) . ($attribute->signature->type =~ /Constructor$/ ? "Constructor" : "");
@@ -1096,7 +1095,7 @@
             }
         }
         
-        if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"})) {
+        if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
             my $getter = "js" . $interfaceName . "Constructor";
             push(@headerContent, "JSC::JSValue ${getter}(JSC::ExecState*, JSC::JSValue, const JSC::Identifier&);\n");
         }
@@ -1137,7 +1136,7 @@
     
     # - Add all attributes in a hashtable definition
     my $numAttributes = @{$dataNode->attributes};
-    $numAttributes++ if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"}));
+    $numAttributes++ if !$dataNode->extendedAttributes->{"OmitConstructor"};
 
     return 0  if !$numAttributes;
 
@@ -1179,7 +1178,7 @@
         }
     }
 
-    if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"})) {
+    if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
         push(@hashKeys, "constructor");
         my $getter = "js" . $interfaceName . "Constructor";
         push(@hashValue1, $getter);
@@ -1338,7 +1337,7 @@
     my $numFunctions = @{$dataNode->functions};
 
     # - Add all constants
-    if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"})) {
+    if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
         my $hashSize = $numConstants;
         my $hashName = $className . "ConstructorTable";
 
@@ -1364,7 +1363,7 @@
 
         my $protoClassName = "${className}Prototype";
 
-        GenerateConstructorDeclaration(\@implContent, $className, $dataNode) unless $dataNode->extendedAttributes->{"CustomConstructFunction"};
+        GenerateConstructorDeclaration(\@implContent, $className, $dataNode) unless ($dataNode->extendedAttributes->{"JSCustomConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"});
         GenerateConstructorDefinition(\@implContent, $className, $protoClassName, $interfaceName, $visibleClassName, $dataNode);
     }
 
@@ -1553,8 +1552,7 @@
     }
 
     my $hasGetter = $numAttributes > 0 
-                 || !($dataNode->extendedAttributes->{"OmitConstructor"} 
-                 || $dataNode->extendedAttributes->{"CustomConstructor"})
+                 || !$dataNode->extendedAttributes->{"OmitConstructor"} 
                  || $dataNode->extendedAttributes->{"HasIndexGetter"}
                  || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}
                  || $dataNode->extendedAttributes->{"HasNumericIndexGetter"}
@@ -1707,7 +1705,7 @@
                 push(@implContent, "\n");
             }
 
-            if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"})) {
+            if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
                 my $constructorFunctionName = "js" . $interfaceName . "Constructor";
 
                 push(@implContent, "JSValue ${constructorFunctionName}(ExecState* exec, JSValue slotBase, const Identifier&)\n");
@@ -1928,7 +1926,7 @@
         push(@implContent, "}\n\n");
     }
 
-    if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"})) {
+    if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
         push(@implContent, "JSValue ${className}::getConstructor(ExecState* exec, JSGlobalObject* globalObject)\n{\n");
         push(@implContent, "    return getDOMConstructor<${className}Constructor>(exec, static_cast<JSDOMGlobalObject*>(globalObject));\n");
         push(@implContent, "}\n\n");
@@ -3170,7 +3168,7 @@
 
     my $constructorClassName = "${className}Constructor";
     my $canConstruct = $dataNode->extendedAttributes->{"CanBeConstructed"};
-    my $customConstructFunction = $dataNode->extendedAttributes->{"CustomConstructFunction"};
+    my $customConstructor = $dataNode->extendedAttributes->{"JSCustomConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"};
     my $callWith = $dataNode->extendedAttributes->{"CallWith"};
     my $numberOfconstructParameters = $dataNode->extendedAttributes->{"ConstructorParameters"};
 
@@ -3204,7 +3202,7 @@
     push(@$outputArray, "}\n\n");
 
     if ($canConstruct) {
-        if (!$customConstructFunction) {
+        if (!$customConstructor) {
             push(@$outputArray, "EncodedJSValue JSC_HOST_CALL ${constructorClassName}::construct${className}(ExecState* exec)\n");
             push(@$outputArray, "{\n");
             my $constructorArg = "";

Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (96787 => 96788)


--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -28,7 +28,7 @@
     // Introduced in DOM Level ?:
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
+        JSCustomConstructor,
         ConstructorParameters=1,
         Constructor(in [Optional=CallWithNullValue] DOMString cssValue),
         ConstructorRaisesException,

Modified: trunk/Source/WebCore/dom/CustomEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/CustomEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/CustomEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -29,8 +29,7 @@
     // Introduced in DOM Level 3:
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor
     ] CustomEvent : Event {
 
        readonly attribute DOMObject detail;

Modified: trunk/Source/WebCore/dom/ErrorEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/ErrorEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/ErrorEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -33,8 +33,7 @@
     interface [
         NoStaticTables,
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor
     ] ErrorEvent : Event {
 
         readonly attribute DOMString message;

Modified: trunk/Source/WebCore/dom/Event.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/Event.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/Event.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -24,8 +24,7 @@
     interface [
         CustomToJS,
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         NoStaticTables,
         Polymorphic
     ] Event {

Modified: trunk/Source/WebCore/dom/HashChangeEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/HashChangeEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/HashChangeEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -22,8 +22,7 @@
     // Introduced in http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#event-hashchange
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor
     ] HashChangeEvent : Event {
         void initHashChangeEvent(in [Optional=CallWithDefaultValue] DOMString type, 
                                  in [Optional=CallWithDefaultValue] boolean canBubble, 

Modified: trunk/Source/WebCore/dom/MessageChannel.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/MessageChannel.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/MessageChannel.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -28,8 +28,7 @@
 
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         CustomMarkFunction,
         NoStaticTables
     ] MessageChannel {

Modified: trunk/Source/WebCore/dom/MessageEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/MessageEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/MessageEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -30,7 +30,7 @@
     interface [
         NoStaticTables,
         CanBeConstructed,
-        CustomConstructFunction
+        JSCustomConstructor
     ] MessageEvent : Event {
         readonly attribute DOMString origin;
         readonly attribute DOMString lastEventId;

Modified: trunk/Source/WebCore/dom/PageTransitionEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/PageTransitionEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/PageTransitionEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor
     ] PageTransitionEvent : Event {
 
         readonly attribute boolean persisted;

Modified: trunk/Source/WebCore/dom/PopStateEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/PopStateEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/PopStateEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -29,8 +29,7 @@
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor,
     ] PopStateEvent : Event {
         void initPopStateEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, 
                                in [Optional=CallWithDefaultValue] boolean canBubbleArg, 

Modified: trunk/Source/WebCore/dom/ProgressEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/ProgressEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/ProgressEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor
     ] ProgressEvent : Event {
         readonly attribute boolean lengthComputable;
         readonly attribute unsigned long long loaded;

Modified: trunk/Source/WebCore/dom/WebKitAnimationEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/dom/WebKitAnimationEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/dom/WebKitAnimationEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor
     ] WebKitAnimationEvent : Event {
      readonly attribute DOMString          animationName;
      readonly attribute double             elapsedTime;

Modified: trunk/Source/WebCore/html/DOMFormData.idl (96787 => 96788)


--- trunk/Source/WebCore/html/DOMFormData.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/DOMFormData.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -32,8 +32,7 @@
 
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         GenerateNativeConverter,
         GenerateToJS
     ] DOMFormData {

Modified: trunk/Source/WebCore/html/canvas/ArrayBuffer.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/ArrayBuffer.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/ArrayBuffer.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -28,9 +28,8 @@
     interface [
         GenerateIsReachable=Impl,
         CanBeConstructed,
-        CustomConstructFunction,
-        NoStaticTables,
-        V8CustomConstructor,
+        CustomConstructor,
+        NoStaticTables
     ] ArrayBuffer {
         readonly attribute int byteLength;
     };

Modified: trunk/Source/WebCore/html/canvas/DataView.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/DataView.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/DataView.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,10 +27,9 @@
 
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
+        CustomConstructor,
         CustomToJS,
         NoStaticTables,
-        V8CustomConstructor
     ] DataView : ArrayBufferView {
         // All these methods raise an exception if they would read or write beyond the end of the view.
 

Modified: trunk/Source/WebCore/html/canvas/Float32Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Float32Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Float32Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/canvas/Float64Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Float64Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Float64Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/canvas/Int16Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Int16Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Int16Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -26,8 +26,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/canvas/Int32Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Int32Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Int32Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/canvas/Int8Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Int8Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Int8Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/canvas/Uint16Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Uint16Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Uint16Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/canvas/Uint32Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Uint32Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Uint32Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/canvas/Uint8Array.idl (96787 => 96788)


--- trunk/Source/WebCore/html/canvas/Uint8Array.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/html/canvas/Uint8Array.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,8 +27,7 @@
 module html {
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         HasNumericIndexGetter,
         HasCustomIndexSetter,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/p2p/PeerConnection.idl (96787 => 96788)


--- trunk/Source/WebCore/p2p/PeerConnection.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/p2p/PeerConnection.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,9 +27,8 @@
     interface [
         Conditional=MEDIA_STREAM,
         CanBeConstructed,
-        CustomConstructFunction,
+        CustomConstructor,
         ConstructorParameters=2,
-        V8CustomConstructor,
         EventTarget
     ] PeerConnection {
         void processSignalingMessage(in DOMString message)

Modified: trunk/Source/WebCore/page/EventSource.idl (96787 => 96788)


--- trunk/Source/WebCore/page/EventSource.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/page/EventSource.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -34,7 +34,7 @@
     interface [
         ActiveDOMObject,
         CanBeConstructed,
-        CustomConstructFunction,
+        JSCustomConstructor,
         ConstructorParameters=1,
         Constructor(in DOMString scriptUrl),
         ConstructorWith=ScriptExecutionContext,

Modified: trunk/Source/WebCore/page/WebKitPoint.idl (96787 => 96788)


--- trunk/Source/WebCore/page/WebKitPoint.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/page/WebKitPoint.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -27,9 +27,8 @@
 
     interface [
         CanBeConstructed,
-        CustomConstructFunction,
+        CustomConstructor,
         ConstructorParameters=2,
-        V8CustomConstructor
     ] WebKitPoint {
         attribute float x;
         attribute float y;

Modified: trunk/Source/WebCore/webaudio/AudioContext.idl (96787 => 96788)


--- trunk/Source/WebCore/webaudio/AudioContext.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/webaudio/AudioContext.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -28,8 +28,7 @@
         Conditional=WEB_AUDIO,
         ActiveDOMObject,
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         CustomMarkFunction,
 #if defined(V8_BINDING) && V8_BINDING
         EventTarget

Modified: trunk/Source/WebCore/websockets/CloseEvent.idl (96787 => 96788)


--- trunk/Source/WebCore/websockets/CloseEvent.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/websockets/CloseEvent.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -33,8 +33,7 @@
     interface [
         NoStaticTables,
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor
+        CustomConstructor
     ] CloseEvent : Event {
         readonly attribute boolean wasClean;
         readonly attribute unsigned short code;

Modified: trunk/Source/WebCore/websockets/WebSocket.idl (96787 => 96788)


--- trunk/Source/WebCore/websockets/WebSocket.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/websockets/WebSocket.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -35,9 +35,8 @@
         Conditional=WEB_SOCKETS,
         ActiveDOMObject,
         CanBeConstructed,
-        CustomConstructFunction,
+        CustomConstructor,
         ConstructorParameters=1,
-        V8CustomConstructor,
         EventTarget,
         NoStaticTables
     ] WebSocket {

Modified: trunk/Source/WebCore/workers/SharedWorker.idl (96787 => 96788)


--- trunk/Source/WebCore/workers/SharedWorker.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/workers/SharedWorker.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -35,9 +35,8 @@
         Conditional=SHARED_WORKERS,
         ActiveDOMObject,
         CanBeConstructed,
-        CustomConstructFunction,
+        CustomConstructor,
         ConstructorParameters=2,
-        V8CustomConstructor,
         CustomMarkFunction,
         GenerateNativeConverter,
         GenerateToJS

Modified: trunk/Source/WebCore/workers/Worker.idl (96787 => 96788)


--- trunk/Source/WebCore/workers/Worker.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/workers/Worker.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -31,7 +31,7 @@
         Conditional=WORKERS,
         ActiveDOMObject,
         CanBeConstructed,
-        CustomConstructFunction,
+        JSCustomConstructor,
         ConstructorParameters=1,
         Constructor(in DOMString scriptUrl),
         ConstructorWith=ScriptExecutionContext,

Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (96787 => 96788)


--- trunk/Source/WebCore/xml/XMLHttpRequest.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -31,8 +31,7 @@
     interface [
         ActiveDOMObject,
         CanBeConstructed,
-        CustomConstructFunction,
-        V8CustomConstructor,
+        CustomConstructor,
         CustomMarkFunction,
         EventTarget,
         NoStaticTables

Modified: trunk/Source/WebCore/xml/XSLTProcessor.idl (96787 => 96788)


--- trunk/Source/WebCore/xml/XSLTProcessor.idl	2011-10-06 05:37:43 UTC (rev 96787)
+++ trunk/Source/WebCore/xml/XSLTProcessor.idl	2011-10-06 06:00:41 UTC (rev 96788)
@@ -35,7 +35,7 @@
     interface [
         Conditional=XSLT,
         CanBeConstructed,
-        CustomConstructFunction,
+        JSCustomConstructor,
         Constructor
     ] XSLTProcessor {
         
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to