Title: [96812] trunk/Source/WebCore
- Revision
- 96812
- Author
- mnaga...@chromium.org
- Date
- 2011-10-06 08:35:01 -0700 (Thu, 06 Oct 2011)
Log Message
Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown.
https://bugs.webkit.org/show_bug.cgi?id=69482
Reviewed by Yury Semikhatsky.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._helpClicked):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (96811 => 96812)
--- trunk/Source/WebCore/ChangeLog 2011-10-06 14:44:49 UTC (rev 96811)
+++ trunk/Source/WebCore/ChangeLog 2011-10-06 15:35:01 UTC (rev 96812)
@@ -1,3 +1,13 @@
+2011-10-05 Mikhail Naganov <mnaga...@chromium.org>
+
+ Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown.
+ https://bugs.webkit.org/show_bug.cgi?id=69482
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/DetailedHeapshotView.js:
+ (WebInspector.DetailedHeapshotView.prototype._helpClicked):
+
2011-10-05 Pavel Feldman <pfeld...@google.com>
Web Inspector: add 10 more front-end classes to the compilation process.
Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (96811 => 96812)
--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2011-10-06 14:44:49 UTC (rev 96811)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2011-10-06 15:35:01 UTC (rev 96812)
@@ -1083,7 +1083,7 @@
_helpClicked: function(event)
{
- if (!this.helpPopover) {
+ if (!this._helpPopoverContentElement) {
var refTypes = ["a:", "console-formatted-name", WebInspector.UIString("property"),
"0:", "console-formatted-name", WebInspector.UIString("element"),
"a:", "console-formatted-number", WebInspector.UIString("context var"),
@@ -1119,7 +1119,8 @@
row.appendChild(objCell);
contentElement.appendChild(row);
}
- this.helpPopover = new WebInspector.Popover(contentElement);
+ this._helpPopoverContentElement = contentElement;
+ this.helpPopover = new WebInspector.Popover();
function appendHelp(help, index, cell)
{
@@ -1138,7 +1139,7 @@
if (this.helpPopover.visible)
this.helpPopover.hide();
else
- this.helpPopover.show(this.helpButton.element);
+ this.helpPopover.show(this._helpPopoverContentElement, this.helpButton.element);
},
_startRetainersHeaderDragging: function(event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
