Title: [96874] trunk/Source/WebCore
- Revision
- 96874
- Author
- m...@apple.com
- Date
- 2011-10-06 16:42:57 -0700 (Thu, 06 Oct 2011)
Log Message
<rdar://problem/9717490> Flash of white when navigating daringfireball.net
https://bugs.webkit.org/show_bug.cgi?id=69581
Reviewed by Darin Adler.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Moved the calls to Scrollbar::setEnabled() into the code
section where invalidation is suppressed if necessary, so that they do not trigger premature invalidation.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (96873 => 96874)
--- trunk/Source/WebCore/ChangeLog 2011-10-06 23:40:22 UTC (rev 96873)
+++ trunk/Source/WebCore/ChangeLog 2011-10-06 23:42:57 UTC (rev 96874)
@@ -1,5 +1,16 @@
2011-10-06 Dan Bernstein <m...@apple.com>
+ <rdar://problem/9717490> Flash of white when navigating daringfireball.net
+ https://bugs.webkit.org/show_bug.cgi?id=69581
+
+ Reviewed by Darin Adler.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::updateScrollbars): Moved the calls to Scrollbar::setEnabled() into the code
+ section where invalidation is suppressed if necessary, so that they do not trigger premature invalidation.
+
+2011-10-06 Dan Bernstein <m...@apple.com>
+
Added a comment explaining code added in r96834.
Suggested by Darin Adler.
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (96873 => 96874)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2011-10-06 23:40:22 UTC (rev 96873)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2011-10-06 23:42:57 UTC (rev 96874)
@@ -532,7 +532,6 @@
if (m_horizontalScrollbar) {
int clientWidth = visibleWidth();
- m_horizontalScrollbar->setEnabled(contentsWidth() > clientWidth);
int pageStep = max(max<int>(clientWidth * Scrollbar::minFractionToStepWhenPaging(), clientWidth - Scrollbar::maxOverlapBetweenPages()), 1);
IntRect oldRect(m_horizontalScrollbar->frameRect());
IntRect hBarRect = IntRect(0,
@@ -545,6 +544,7 @@
if (m_scrollbarsSuppressed)
m_horizontalScrollbar->setSuppressInvalidation(true);
+ m_horizontalScrollbar->setEnabled(contentsWidth() > clientWidth);
m_horizontalScrollbar->setSteps(Scrollbar::pixelsPerLineStep(), pageStep);
m_horizontalScrollbar->setProportion(clientWidth, contentsWidth());
if (m_scrollbarsSuppressed)
@@ -553,7 +553,6 @@
if (m_verticalScrollbar) {
int clientHeight = visibleHeight();
- m_verticalScrollbar->setEnabled(contentsHeight() > clientHeight);
int pageStep = max(max<int>(clientHeight * Scrollbar::minFractionToStepWhenPaging(), clientHeight - Scrollbar::maxOverlapBetweenPages()), 1);
IntRect oldRect(m_verticalScrollbar->frameRect());
IntRect vBarRect = IntRect(width() - m_verticalScrollbar->width(),
@@ -566,6 +565,7 @@
if (m_scrollbarsSuppressed)
m_verticalScrollbar->setSuppressInvalidation(true);
+ m_verticalScrollbar->setEnabled(contentsHeight() > clientHeight);
m_verticalScrollbar->setSteps(Scrollbar::pixelsPerLineStep(), pageStep);
m_verticalScrollbar->setProportion(clientHeight, contentsHeight());
if (m_scrollbarsSuppressed)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
