- Revision
- 97424
- Author
- hara...@chromium.org
- Date
- 2011-10-13 16:45:43 -0700 (Thu, 13 Oct 2011)
Log Message
Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
https://bugs.webkit.org/show_bug.cgi?id=69801
As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.
Reviewed by Adam Barth.
No new tests, since no change in behavior.
* bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.
(GenerateConstructorCallback):
* bindings/scripts/test/TestInterface.idl: Ditto.
* fileapi/FileReader.idl: Ditto.
* p2p/PeerConnection.idl: Ditto.
* page/EventSource.idl: Ditto.
* workers/Worker.idl: Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97423 => 97424)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 23:45:43 UTC (rev 97424)
@@ -1,5 +1,25 @@
2011-10-13 Kentaro Hara <hara...@chromium.org>
+ Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
+ https://bugs.webkit.org/show_bug.cgi?id=69801
+
+ As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
+ We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.
+
+ Reviewed by Adam Barth.
+
+ No new tests, since no change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.
+ (GenerateConstructorCallback):
+ * bindings/scripts/test/TestInterface.idl: Ditto.
+ * fileapi/FileReader.idl: Ditto.
+ * p2p/PeerConnection.idl: Ditto.
+ * page/EventSource.idl: Ditto.
+ * workers/Worker.idl: Ditto.
+
+2011-10-13 Kentaro Hara <hara...@chromium.org>
+
Constructor should not be called if the object is being constructed inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=70015
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (97423 => 97424)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-13 23:45:43 UTC (rev 97424)
@@ -1548,7 +1548,7 @@
push(@implContent, $parameterCheckString);
my @contextArgument;
- if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") {
+ if ($dataNode->extendedAttributes->{"CallWith"} && $dataNode->extendedAttributes->{"CallWith"} eq "ScriptExecutionContext") {
push(@contextArgument, "context");
push(@implContent, <<END);
Modified: trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl (97423 => 97424)
--- trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -34,7 +34,6 @@
CanBeConstructed,
CallWith=ScriptExecutionContext,
Constructor(in DOMString str1, in [Optional=CallWithDefaultValue] DOMString str2),
- ConstructorWith=ScriptExecutionContext,
V8ConstructorSetsActiveDOMWrapper,
ConstructorRaisesException
] TestInterface {
Modified: trunk/Source/WebCore/fileapi/FileReader.idl (97423 => 97424)
--- trunk/Source/WebCore/fileapi/FileReader.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/fileapi/FileReader.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -38,7 +38,6 @@
EventTarget,
NoStaticTables,
Constructor,
- ConstructorWith=ScriptExecutionContext,
V8ConstructorSetsActiveDOMWrapper
] FileReader {
// ready states
Modified: trunk/Source/WebCore/p2p/PeerConnection.idl (97423 => 97424)
--- trunk/Source/WebCore/p2p/PeerConnection.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/p2p/PeerConnection.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -30,7 +30,7 @@
CanBeConstructed,
ConstructorParameters=2,
Constructor(in DOMString serverConfiguration, in [Callback=FunctionOnly] SignalingCallback signalingCallback),
- ConstructorWith=ScriptExecutionContext,
+ CallWith=ScriptExecutionContext,
JSCustomConstructor,
V8ConstructorSetsActiveDOMWrapper,
EventTarget
Modified: trunk/Source/WebCore/page/EventSource.idl (97423 => 97424)
--- trunk/Source/WebCore/page/EventSource.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/page/EventSource.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -37,7 +37,7 @@
JSCustomConstructor,
ConstructorParameters=1,
Constructor(in DOMString scriptUrl),
- ConstructorWith=ScriptExecutionContext,
+ CallWith=ScriptExecutionContext,
ConstructorRaisesException,
V8ConstructorSetsActiveDOMWrapper,
EventTarget,
Modified: trunk/Source/WebCore/workers/Worker.idl (97423 => 97424)
--- trunk/Source/WebCore/workers/Worker.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/workers/Worker.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -34,7 +34,7 @@
JSCustomConstructor,
ConstructorParameters=1,
Constructor(in DOMString scriptUrl),
- ConstructorWith=ScriptExecutionContext,
+ CallWith=ScriptExecutionContext,
ConstructorRaisesException,
V8ConstructorSetsActiveDOMWrapper,
GenerateNativeConverter,
