Title: [97651] trunk/LayoutTests
- Revision
- 97651
- Author
- a...@chromium.org
- Date
- 2011-10-17 14:41:36 -0700 (Mon, 17 Oct 2011)
Log Message
REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails
https://bugs.webkit.org/show_bug.cgi?id=70210
Reviewed by Darin Adler.
Change the test to not call debug() inside the test functions since that fails on V8
because we are already at the maximum allowed stack depth.
* fast/js/script-tests/stack-overflow-arrity-catch.js:
(test1): Changed to not call debug but set a boolean variable that is later checked.
(test2): Ditto.
* fast/js/stack-overflow-arrity-catch-expected.txt:
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (97650 => 97651)
--- trunk/LayoutTests/ChangeLog 2011-10-17 21:29:13 UTC (rev 97650)
+++ trunk/LayoutTests/ChangeLog 2011-10-17 21:41:36 UTC (rev 97651)
@@ -1,3 +1,19 @@
+2011-10-17 Erik Arvidsson <a...@chromium.org>
+
+ REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=70210
+
+ Reviewed by Darin Adler.
+
+ Change the test to not call debug() inside the test functions since that fails on V8
+ because we are already at the maximum allowed stack depth.
+
+ * fast/js/script-tests/stack-overflow-arrity-catch.js:
+ (test1): Changed to not call debug but set a boolean variable that is later checked.
+ (test2): Ditto.
+ * fast/js/stack-overflow-arrity-catch-expected.txt:
+ * platform/chromium/test_expectations.txt:
+
2011-10-17 Dirk Pranke <dpra...@chromium.org>
Removing suppressions for the fullscreen/ tests - it looks
Modified: trunk/LayoutTests/fast/js/script-tests/stack-overflow-arrity-catch.js (97650 => 97651)
--- trunk/LayoutTests/fast/js/script-tests/stack-overflow-arrity-catch.js 2011-10-17 21:29:13 UTC (rev 97650)
+++ trunk/LayoutTests/fast/js/script-tests/stack-overflow-arrity-catch.js 2011-10-17 21:41:36 UTC (rev 97651)
@@ -7,7 +7,7 @@
debug("ERROR: Shouldn't arrive in 20 arg function!");
}
-gotRightCatch = false;
+var gotRightCatch = false, gotWrongCatch1 = false, gotWrongCatch2 = false;
function test1()
{
@@ -19,7 +19,7 @@
try {
var dummy = new RegExp('a|b|c');
} catch(err) {
- debug('Should not get here #1!');
+ gotWrongCatch1 = true;
}
try {
@@ -35,7 +35,7 @@
try {
var dummy = new Date();
} catch(err) {
- debug('Should not get here #2!');
+ gotWrongCatch2 = true;
}
try {
@@ -54,5 +54,7 @@
test1();
shouldBeTrue("gotRightCatch");
+shouldBeFalse("gotWrongCatch1");
+shouldBeFalse("gotWrongCatch2");
var successfullyParsed = true;
Modified: trunk/LayoutTests/fast/js/stack-overflow-arrity-catch-expected.txt (97650 => 97651)
--- trunk/LayoutTests/fast/js/stack-overflow-arrity-catch-expected.txt 2011-10-17 21:29:13 UTC (rev 97650)
+++ trunk/LayoutTests/fast/js/stack-overflow-arrity-catch-expected.txt 2011-10-17 21:41:36 UTC (rev 97651)
@@ -4,6 +4,8 @@
PASS gotRightCatch is true
+PASS gotWrongCatch1 is false
+PASS gotWrongCatch2 is false
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97650 => 97651)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-17 21:29:13 UTC (rev 97650)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-17 21:41:36 UTC (rev 97651)
@@ -3824,7 +3824,7 @@
BUGV8_1768 : fast/js/delete-syntax.html = TEXT
-// REGRESSION(97566?)
+// V8 handles stack overflow exceptions differently than JSC
BUGWK70210 : fast/js/stack-overflow-arrity-catch.html = TEXT
// These all will timeout, because we are lacking a hook that signals test completion.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
