Title: [97951] trunk/Source/_javascript_Core
Revision
97951
Author
fpi...@apple.com
Date
2011-10-20 02:10:06 -0700 (Thu, 20 Oct 2011)

Log Message

https://bugs.webkit.org/show_bug.cgi?id=70482
DFG-related stubs in the old JIT should not be built if the DFG is disabled

Reviewed by Zoltan Herczeg.
        
Aiming for a slight code size/build time reduction if the DFG is not in
play. This should also make further DFG development slightly easier since
the bodies of these JIT stubs can now safely refer to things that are only
declared when the DFG is enabled.

* jit/JITStubs.cpp:
* jit/JITStubs.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (97950 => 97951)


--- trunk/Source/_javascript_Core/ChangeLog	2011-10-20 08:19:55 UTC (rev 97950)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-10-20 09:10:06 UTC (rev 97951)
@@ -1,3 +1,18 @@
+2011-10-20  Filip Pizlo  <fpi...@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=70482
+        DFG-related stubs in the old JIT should not be built if the DFG is disabled
+
+        Reviewed by Zoltan Herczeg.
+        
+        Aiming for a slight code size/build time reduction if the DFG is not in
+        play. This should also make further DFG development slightly easier since
+        the bodies of these JIT stubs can now safely refer to things that are only
+        declared when the DFG is enabled.
+
+        * jit/JITStubs.cpp:
+        * jit/JITStubs.h:
+
 2011-10-19  Filip Pizlo  <fpi...@apple.com>
 
         DFG ConvertThis emits slow code when the source node is known to be,

Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (97950 => 97951)


--- trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-10-20 08:19:55 UTC (rev 97950)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-10-20 09:10:06 UTC (rev 97951)
@@ -1902,6 +1902,7 @@
     VM_THROW_EXCEPTION_AT_END();
 }
 
+#if ENABLE(DFG_JIT)
 DEFINE_STUB_FUNCTION(void, optimize_from_loop)
 {
     STUB_INIT_STACK_FRAME(stackFrame);
@@ -2058,6 +2059,7 @@
     
     codeBlock->optimizeSoon();
 }
+#endif // ENABLE(DFG_JIT)
 
 DEFINE_STUB_FUNCTION(EncodedJSValue, op_instanceof)
 {

Modified: trunk/Source/_javascript_Core/jit/JITStubs.h (97950 => 97951)


--- trunk/Source/_javascript_Core/jit/JITStubs.h	2011-10-20 08:19:55 UTC (rev 97950)
+++ trunk/Source/_javascript_Core/jit/JITStubs.h	2011-10-20 09:10:06 UTC (rev 97951)
@@ -425,8 +425,10 @@
     void JIT_STUB cti_op_tear_off_activation(STUB_ARGS_DECLARATION);
     void JIT_STUB cti_op_tear_off_arguments(STUB_ARGS_DECLARATION);
     void JIT_STUB cti_op_throw_reference_error(STUB_ARGS_DECLARATION);
+#if ENABLE(DFG_JIT)
     void JIT_STUB cti_optimize_from_loop(STUB_ARGS_DECLARATION);
     void JIT_STUB cti_optimize_from_ret(STUB_ARGS_DECLARATION);
+#endif
     void* JIT_STUB cti_op_call_arityCheck(STUB_ARGS_DECLARATION);
     void* JIT_STUB cti_op_construct_arityCheck(STUB_ARGS_DECLARATION);
     void* JIT_STUB cti_op_call_jitCompile(STUB_ARGS_DECLARATION);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to