Title: [98064] trunk/Tools
- Revision
- 98064
- Author
- yu...@chromium.org
- Date
- 2011-10-20 21:14:10 -0700 (Thu, 20 Oct 2011)
Log Message
WebSocket: Connecting to localhost:8880 takes one second on Windows
https://bugs.webkit.org/show_bug.cgi?id=64788
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
from timing out on Windows, because this test tries to open a lot of
connections to localhost and each attempt takes one second to fall back from
IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (98063 => 98064)
--- trunk/Tools/ChangeLog 2011-10-21 04:01:28 UTC (rev 98063)
+++ trunk/Tools/ChangeLog 2011-10-21 04:14:10 UTC (rev 98064)
@@ -1,3 +1,17 @@
+2011-10-20 Yuta Kitamura <yu...@chromium.org>
+
+ WebSocket: Connecting to localhost:8880 takes one second on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=64788
+
+ Reviewed by Dirk Pranke.
+
+ * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
+ Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
+ IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
+ from timing out on Windows, because this test tries to open a lot of
+ connections to localhost and each attempt takes one second to fall back from
+ IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
+
2011-10-20 Ryosuke Niwa <rn...@webkit.org>
nrwt: newly generated results are put in cross-platform directory
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py (98063 => 98064)
--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-21 04:01:28 UTC (rev 98063)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-21 04:14:10 UTC (rev 98064)
@@ -117,7 +117,7 @@
pywebsocket_script = self._filesystem.join(pywebsocket_base, 'mod_pywebsocket', 'standalone.py')
start_cmd = [
python_interp, '-u', pywebsocket_script,
- '--server-host', '127.0.0.1',
+ '--server-host', 'localhost',
'--port', str(self._port),
# FIXME: Don't we have a self._port_obj.layout_test_path?
'--document-root', self._filesystem.join(self._layout_tests, 'http', 'tests'),
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
