Title: [98074] trunk/Tools
- Revision
- 98074
- Author
- e...@webkit.org
- Date
- 2011-10-20 23:49:08 -0700 (Thu, 20 Oct 2011)
Log Message
Switch webkit2 bot to NRWT
https://bugs.webkit.org/show_bug.cgi?id=56729
Reviewed by Adam Barth.
Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
* Scripts/run-webkit-tests:
(runningOnBuildBot):
(useNewRunWebKitTests):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (98073 => 98074)
--- trunk/Tools/ChangeLog 2011-10-21 06:47:05 UTC (rev 98073)
+++ trunk/Tools/ChangeLog 2011-10-21 06:49:08 UTC (rev 98074)
@@ -1,5 +1,19 @@
2011-10-20 Eric Seidel <e...@webkit.org>
+ Switch webkit2 bot to NRWT
+ https://bugs.webkit.org/show_bug.cgi?id=56729
+
+ Reviewed by Adam Barth.
+
+ Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
+ https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
+
+ * Scripts/run-webkit-tests:
+ (runningOnBuildBot):
+ (useNewRunWebKitTests):
+
+2011-10-20 Eric Seidel <e...@webkit.org>
+
NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=70585
Modified: trunk/Tools/Scripts/run-webkit-tests (98073 => 98074)
--- trunk/Tools/Scripts/run-webkit-tests 2011-10-21 06:47:05 UTC (rev 98073)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-10-21 06:49:08 UTC (rev 98074)
@@ -55,16 +55,6 @@
return $isBuildBotUser{$ENV{"USER"}};
}
-# We could use isWebKit2() instead of our own custom usingWebKit2(), but then
-# we'd have to be careful to add -2 or --webkit-test-runner back into @ARGV below.
-sub usingWebKit2()
-{
- # If either -2 or --webkit-test-runner is passed, we're supposed to use WebKit2.
- # NRWT's WebKit2 support is still a work in progress:
- # https://bugs.webkit.org/show_bug.cgi?id=56729
- return grep(/(-2|--webkit-test-runner)/, @ARGV);
-}
-
sub usingLeaks()
{
# LeaksViewer gets confused by NRWT's --leaks output, see bugs:
@@ -90,7 +80,7 @@
return (!isDarwin() and !isARM());
}
- return ((isLeopard() or isSnowLeopard() or isLion() or isGtk()) and !usingWebKit2() and !usingLeaks());
+ return ((isLeopard() or isSnowLeopard() or isLion() or isGtk()) and !usingLeaks());
}
my $harnessName = "old-run-webkit-tests";
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
