Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ba6a9fa393e478b5aafa4a0519287bb0ccb7f8d https://github.com/WebKit/WebKit/commit/1ba6a9fa393e478b5aafa4a0519287bb0ccb7f8d Author: Vitaly Dyachkov <vit...@igalia.com> Date: 2023-07-11 (Tue, 11 Jul 2023)
Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp M Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: ----------- [GLib] API test `/webkit/WebKitSettings/webkit-settings` is failing https://bugs.webkit.org/show_bug.cgi?id=259049 Reviewed by Michael Catanzaro. The test was failing because `webkit_settings_get_load_icons_ignoring_image_load_setting()` and `webkit_settings_set_load_icons_ignoring_image_load_setting()` are deprecated and issue a `g_warning()` which is fatal by default in Glib tests. The solution is to temporarily remove `G_LOG_LEVEL_WARNING` from fatals. Also, unlike some other similar deprecated API functions, these two were not marked as `WEBKIT_DEPRECATED`. * Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: (webKitSettingsSetProperty): (webKitSettingsGetProperty): (webkit_settings_class_init): * Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in: * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: (testWebKitSettings): (testWebKitSettingsNewWithSettings): * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/265946@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes