Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c9711b76a350d4ae9959ddacceb6f7ccc177d22 https://github.com/WebKit/WebKit/commit/1c9711b76a350d4ae9959ddacceb6f7ccc177d22 Author: Rob Buis <rb...@igalia.com> Date: 2023-05-11 (Thu, 11 May 2023)
Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-no-throw-requested-state-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-no-throw-requested-state.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-move-documents.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt M Source/WebCore/html/HTMLDialogElement.cpp M Source/WebCore/html/HTMLElement.cpp Log Message: ----------- [popover] Don't throw when popover/dialog is in requested state https://bugs.webkit.org/show_bug.cgi?id=255879 Reviewed by Tim Nguyen. Implement the spec changes from: https://github.com/whatwg/html/pull/9142 The dialog related changes are tested by dialog-no-throw-requested-state.html. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-no-throw-requested-state-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-no-throw-requested-state.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-move-documents.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js: (async sendTab): (async sendEscape): (async sendEnter): (assertPopoverVisibility): * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt: * Source/WebCore/html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::show): (WebCore::HTMLDialogElement::showModal): * Source/WebCore/html/HTMLElement.cpp: (WebCore::checkPopoverValidity): (WebCore::HTMLElement::showPopover): (WebCore::HTMLElement::hidePopoverInternal): Canonical link: https://commits.webkit.org/263957@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes