Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2216a54223af1e12f2e64dc08c74fc09c86b5016 https://github.com/WebKit/WebKit/commit/2216a54223af1e12f2e64dc08c74fc09c86b5016 Author: Mike Wyrzykowski <mwyrzykow...@apple.com> Date: 2024-02-16 (Fri, 16 Feb 2024)
Changed paths: M Source/WebGPU/WebGPU/BindGroup.mm M Source/WebGPU/WebGPU/BindableResource.h M Source/WebGPU/WebGPU/ComputePassEncoder.h M Source/WebGPU/WebGPU/ComputePassEncoder.mm M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebGPU/WebGPU/TextureView.h Log Message: ----------- [WebGPU] https://webgpu.github.io/webgpu-samples/samples/deferredRendering has an error in Queue::submit https://bugs.webkit.org/show_bug.cgi?id=269600 <radar://123106092> Reviewed by Cameron McCormack. 274518@main used the address of the MTLResource as a handle, the problem appears to be that multiple MTLBuffers can share the same address when bridged-casted. Instead of relying on that behavior, use the address of the WebGPU resource which we know to be unique. * Source/WebGPU/WebGPU/BindGroup.mm: (WebGPU::makeBindGroupEntryUsageData): * Source/WebGPU/WebGPU/BindableResource.h: * Source/WebGPU/WebGPU/ComputePassEncoder.h: * Source/WebGPU/WebGPU/ComputePassEncoder.mm: (WebGPU::addResourceToActiveResources): (WebGPU::ComputePassEncoder::executePreDispatchCommands): (WebGPU::ComputePassEncoder::dispatchIndirect): (WebGPU::setCommandEncoder): * Source/WebGPU/WebGPU/RenderBundleEncoder.h: * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::addResource): (WebGPU::RenderBundleEncoder::drawIndexedIndirect): (WebGPU::RenderBundleEncoder::drawIndirect): (WebGPU::RenderBundleEncoder::setIndexBuffer): (WebGPU::RenderBundleEncoder::setVertexBuffer): * Source/WebGPU/WebGPU/RenderPassEncoder.h: * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::addResourceToActiveResources): (WebGPU::RenderPassEncoder::executePreDrawCommands): (WebGPU::RenderPassEncoder::drawIndexedIndirect): (WebGPU::RenderPassEncoder::drawIndirect): (WebGPU::RenderPassEncoder::setCommandEncoder): (WebGPU::RenderPassEncoder::setIndexBuffer): (WebGPU::RenderPassEncoder::setVertexBuffer): * Source/WebGPU/WebGPU/TextureView.h: (WebGPU::TextureView::apiParentTexture const): Canonical link: https://commits.webkit.org/274902@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes