Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2326b1146886546de0d44f6aa85415b2e1257b8a
https://github.com/WebKit/WebKit/commit/2326b1146886546de0d44f6aa85415b2e1257b8a
Author: Patrick Angle <pan...@apple.com>
Date: 2022-09-20 (Tue, 20 Sep 2022)
Changed paths:
M Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml
M Source/WebCore/inspector/InspectorFrontendHost.cpp
M Source/WebCore/inspector/InspectorFrontendHost.h
M Source/WebCore/inspector/InspectorFrontendHost.idl
M Source/WebInspectorUI/UserInterface/Base/Main.js
M Source/WebInspectorUI/UserInterface/Base/Setting.js
M Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js
M Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
M Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js
M Source/WebInspectorUI/UserInterface/Test/Test.js
M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
Log Message:
-----------
Web Inspector: Make frontend engineering settings available behind a debug
runtime flag
https://bugs.webkit.org/show_bug.cgi?id=244819
rdar://98957031
Reviewed by Devin Rousso.
Make it slightly easier to use the engineering settings by allowing platforms
to define various additional circumstances
under which engineering settings are available.
This is not done as additional functionality behind `DeveloperExtrasEnabled`,
as that setting is currently used in some
applications to enable the "Inspect Element" context menu item, but these
settings are not generally useful for the
users of those applications.
"Debug" settings and functionality remain limited to local engineering builds.
* Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml:
- Add a runtime preference to control engineering setting availability.
* Source/WebCore/inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::engineeringSettingsAllowed):
* Source/WebCore/inspector/InspectorFrontendHost.h:
* Source/WebCore/inspector/InspectorFrontendHost.idl:
* Source/WebInspectorUI/UserInterface/Base/Main.js:
* Source/WebInspectorUI/UserInterface/Test/Test.js:
* Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.initializeTarget):
* Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype.async initializeTarget):
- Add helper to determine if engineering settings should be available based on
both the preference and the actual build.
* Source/WebInspectorUI/UserInterface/Base/Setting.js:
(WI.EngineeringSetting.prototype.get value):
(WI.EngineeringSetting.prototype.set value):
(WI.EngineeringSetting):
* Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype.initialLayout):
(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):
(WI.SettingsTabContentView.prototype._createDebugSettingsView):
* Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js:
(updateMockWebExtensionTab):
(WI.runBootstrapOperations):
- Move the mock inspector extension tab setting to the Debug section, since it
relies on Debug/Bootstrap.js being in the
build.
Canonical link: https://commits.webkit.org/254676@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
