Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27ac548bef6ea93a00857b33ca9bbefa811391ef https://github.com/WebKit/WebKit/commit/27ac548bef6ea93a00857b33ca9bbefa811391ef Author: Brent Fulgham <bfulg...@apple.com> Date: 2023-01-20 (Fri, 20 Jan 2023)
Changed paths: M LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html M LayoutTests/media/ios/autoplay-only-in-main-document.html M LayoutTests/media/loadedmetadata-fires-without-user-gesture-when-setRequiresUserGestureToLoadVideo-false.html M LayoutTests/media/no-autoplay-with-user-gesture-requirement.html M LayoutTests/media/playlist-inherits-user-gesture-expected.txt M LayoutTests/media/playlist-inherits-user-gesture.html M LayoutTests/media/video-add-autoplay-user-gesture-expected.txt M LayoutTests/media/video-add-autoplay-user-gesture.html M LayoutTests/media/video-create-with-user-gesture-expected.txt M LayoutTests/media/video-create-with-user-gesture.html M LayoutTests/media/video-load-require-user-gesture.html M LayoutTests/media/video-source-before-src-expected.txt M LayoutTests/media/video-source-before-src.html M LayoutTests/media/video-user-gesture-tracking-expected.txt M LayoutTests/media/video-user-gesture-tracking.html M LayoutTests/platform/ios/media/video-source-before-src-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Modules/speech/SpeechSynthesis.cpp M Source/WebCore/Modules/webaudio/AudioContext.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/page/Settings.yaml M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/WebView/WebView.mm M Source/WebKitLegacy/win/WebView.cpp Log Message: ----------- Use consistent settings between WebKit/WebKitLegacy/WebCore for audio and video gesture requirements https://bugs.webkit.org/show_bug.cgi?id=250858 <rdar://problem/104440786> Reviewed by Jer Noble. We currently have different names used for WebCore-related media gesture requirements, and the preferences in WebKitLegacy and WebKit with custom code to toggle the WebCore bits in response to the WebKit/WebKitLegacy settings. Instead, we should let the generator code create the WebCore settings code, which will automatically sync it when WebKit/WebKitLegacy preferences are adjusted. Since the internal keys used to control the settings are unchanged, this should not modify behavior. * LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html: Update generated 'internals' method call to match Settings. * LayoutTests/media/ios/autoplay-only-in-main-document.html: Ditto. * LayoutTests/media/loadedmetadata-fires-without-user-gesture-when-setRequiresUserGestureToLoadVideo-false.html: Ditto. * LayoutTests/media/no-autoplay-with-user-gesture-requirement.html: Ditto. * LayoutTests/media/playlist-inherits-user-gesture-expected.txt: Ditto. * LayoutTests/media/playlist-inherits-user-gesture.html: Ditto. * LayoutTests/media/video-add-autoplay-user-gesture-expected.txt: Ditto. * LayoutTests/media/video-add-autoplay-user-gesture.html: Ditto. * LayoutTests/media/video-create-with-user-gesture-expected.txt: Ditto. * LayoutTests/media/video-create-with-user-gesture.html: Ditto. * LayoutTests/media/video-load-require-user-gesture.html: Ditto. * LayoutTests/media/video-source-before-src-expected.txt: Ditto. * LayoutTests/media/video-source-before-src.html: Ditto. * LayoutTests/media/video-user-gesture-tracking-expected.txt: Ditto. * LayoutTests/media/video-user-gesture-tracking.html: Ditto. * LayoutTests/platform/ios/media/video-source-before-src-expected.txt: Ditto. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/speech/SpeechSynthesis.cpp: (WebCore::SpeechSynthesis::SpeechSynthesis): * Source/WebCore/Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::constructCommon): * Source/WebCore/dom/Document.cpp: (WebCore::Document::requiresUserGestureForAudioPlayback const): (WebCore::Document::requiresUserGestureForVideoPlayback const): (WebCore::Document::audioPlaybackRequiresUserGesture const): Deleted. (WebCore::Document::videoPlaybackRequiresUserGesture const): Deleted. * Source/WebCore/dom/Document.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::initializeMediaSession): (WebCore::HTMLMediaElement::updateRateChangeRestrictions): * Source/WebCore/page/Settings.yaml: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Update for generated Settings labels. * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _preferencesChanged:]): Ditto. * Source/WebKitLegacy/win/WebView.cpp: (WebView::notifyPreferencesChanged): Ditto. Canonical link: https://commits.webkit.org/259163@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes