Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 28ec4a08ef0a78d852aad9a1a6b7392c3c9dd3c5 https://github.com/WebKit/WebKit/commit/28ec4a08ef0a78d852aad9a1a6b7392c3c9dd3c5 Author: Timothy Hatcher <timo...@apple.com> Date: 2024-04-11 (Thu, 11 Apr 2024)
Changed paths: M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm Log Message: ----------- Missing result from Web Extension storage get() with empty string key. https://webkit.org/b/272542 rdar://problem/126290503 Reviewed by Brian Weinstein. Allow getting an empty key from storage, we already allowed setting it. It was also working when using an array of keys, but not a string key. Bug details: https://github.com/lapcat/SafariExtensions/issues/12 * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm: (WebKit::WebExtensionAPIStorageArea::get): Don't return early if the key is empty. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm: (TestWebKitAPI::TEST(WKWebExtensionAPIStorage, Get)): Add tests for empty key. Canonical link: https://commits.webkit.org/277401@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes