Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 449b54f22d5ffc59b830838126d7e342e8748e0a https://github.com/WebKit/WebKit/commit/449b54f22d5ffc59b830838126d7e342e8748e0a Author: Anne van Kesteren <ann...@annevk.nl> Date: 2023-08-22 (Tue, 22 Aug 2023)
Changed paths: R LayoutTests/fast/html/menuitem-element-expected.txt R LayoutTests/fast/html/menuitem-element.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/WebCoreBuiltinNames.h M Source/WebCore/html/HTMLMenuElement.cpp M Source/WebCore/html/HTMLMenuElement.h R Source/WebCore/html/HTMLMenuItemElement.cpp R Source/WebCore/html/HTMLMenuItemElement.h R Source/WebCore/html/HTMLMenuItemElement.idl M Source/WebCore/html/HTMLTagNames.in M Source/WebCore/page/ChromeClient.h M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h R Source/WebKit/Shared/TouchBarMenuData.cpp R Source/WebKit/Shared/TouchBarMenuData.h R Source/WebKit/Shared/TouchBarMenuItemData.cpp R Source/WebKit/Shared/TouchBarMenuItemData.h R Source/WebKit/Shared/TouchBarMenuItemData.serialization.in M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h Log Message: ----------- Remove menuitem element and some leftover touchbar code https://bugs.webkit.org/show_bug.cgi?id=260428 rdar://114132124 Reviewed by Wenson Hsieh. This code does not do anything and as such it is better to remove it to ease ongoing maintenance. This deprecates and no-ops WKPreferencesSetMenuItemElementEnabled and WKPreferencesGetMenuItemElementEnabled in order to preserve binary compatibility. Due to file removal a couple unified build fixes were needed. Those are annotated inline below. * LayoutTests/fast/html/menuitem-element-expected.txt: Removed. * LayoutTests/fast/html/menuitem-element.html: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/html/HTMLMenuElement.cpp: (WebCore::HTMLMenuElement::insertedIntoAncestor): Deleted. (WebCore::HTMLMenuElement::removedFromAncestor): Deleted. (WebCore::HTMLMenuElement::attributeChanged): Deleted. * Source/WebCore/html/HTMLMenuElement.h: * Source/WebCore/html/HTMLMenuItemElement.cpp: Removed. * Source/WebCore/html/HTMLMenuItemElement.h: Removed. * Source/WebCore/html/HTMLMenuItemElement.idl: Removed. * Source/WebCore/html/HTMLTagNames.in: * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::didInsertMenuElement): Deleted. (WebCore::ChromeClient::didRemoveMenuElement): Deleted. (WebCore::ChromeClient::didInsertMenuItemElement): Deleted. (WebCore::ChromeClient::didRemoveMenuItemElement): Deleted. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h: Unified build fix. * Source/WebKit/Shared/TouchBarMenuData.cpp: Removed. * Source/WebKit/Shared/TouchBarMenuData.h: Removed. * Source/WebKit/Shared/TouchBarMenuItemData.cpp: Removed. * Source/WebKit/Shared/TouchBarMenuItemData.h: Removed. * Source/WebKit/Shared/TouchBarMenuItemData.serialization.in: Removed. * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetMenuItemElementEnabled): Deleted. (WKPreferencesGetMenuItemElementEnabled): Deleted. * Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::touchBarMenuDataChanged): Deleted. (WebKit::WebPageProxy::touchBarMenuItemDataAdded): Deleted. (WebKit::WebPageProxy::touchBarMenuItemDataRemoved): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didInsertMenuElement): Deleted. (WebKit::WebChromeClient::didRemoveMenuElement): Deleted. (WebKit::WebChromeClient::didInsertMenuItemElement): Deleted. (WebKit::WebChromeClient::didRemoveMenuItemElement): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didInsertMenuElement): Deleted. (WebKit::WebPage::didRemoveMenuElement): Deleted. (WebKit::WebPage::didInsertMenuItemElement): Deleted. (WebKit::WebPage::didRemoveMenuItemElement): Deleted. (WebKit::WebPage::sendTouchBarMenuDataRemovedUpdate): Deleted. (WebKit::WebPage::sendTouchBarMenuDataAddedUpdate): Deleted. (WebKit::WebPage::sendTouchBarMenuItemDataAddedUpdate): Deleted. (WebKit::WebPage::sendTouchBarMenuItemDataRemovedUpdate): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: Includes unified build fix. * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences menuItemElementEnabled]): Deleted. (-[WebPreferences setMenuItemElementEnabled:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: Canonical link: https://commits.webkit.org/267140@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes