Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5092e5de93782ddb9e2be8a9504f55a66a7e4616 https://github.com/WebKit/WebKit/commit/5092e5de93782ddb9e2be8a9504f55a66a7e4616 Author: Megan Gardner <megan_gard...@apple.com> Date: 2024-05-14 (Tue, 14 May 2024)
Changed paths: M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/UnifiedTextReplacement.serialization.in M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm M Source/WebKit/UIProcess/Cocoa/WKTextIndicatorStyleType.h M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/PageClient.h A Source/WebKit/UIProcess/TextIndicatorStyle.h M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: ----------- Implement source textIndicators. https://bugs.webkit.org/show_bug.cgi?id=274176 rdar://128080035 Reviewed by Aditya Keerthi. Implement source text indicators based on character ranges of the original range to avoid issues when ranges are collapsed after text is replaced. * Source/WebKit/Scripts/webkit/messages.py: (headers_for_type): * Source/WebKit/Shared/UnifiedTextReplacement.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _addTextIndicatorStyleForID:withStyleType:]): (-[WKWebView _removeTextIndicatorStyleForID:]): (-[WKWebView _enableTextIndicatorStylingAfterElementWithID:]): (-[WKWebView _disableTextIndicatorStylingWithUUID:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h: * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::addTextIndicatorStyleForID): * Source/WebKit/UIProcess/Cocoa/WKTextIndicatorStyleType.h: * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::addTextIndicatorStyleForID): (WebKit::WebPageProxy::getTextIndicatorForID): * Source/WebKit/UIProcess/PageClient.h: * Source/WebKit/UIProcess/TextIndicatorStyle.h: Copied from Source/WebKit/UIProcess/Cocoa/WKTextIndicatorStyleType.h. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView targetedPreviewForID:withStyle:completionHandler:]): (-[WKContentView targetedPreviewForID:completionHandler:]): Deleted. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements): (WebKit::UnifiedTextReplacementController::didEndTextReplacementSession): (WebKit::UnifiedTextReplacementController::removeTransparentMarkersForSession): (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange): (WebKit::UnifiedTextReplacementController::contextRangeForSessionOrRangeWithUUID const): * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::getRangeForUUID): (WebKit::WebPage::createTextIndicatorForRange): (WebKit::WebPage::createTextIndicatorForID): (WebKit::WebPage::updateTextIndicatorStyleVisibilityForID): (WebKit::WebPage::getTextIndicatorForID): Deleted. * Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::addTextIndicatorStyleForID): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/278793@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes