Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58f6c8c908495ef98006509e0142d15225c64be9 https://github.com/WebKit/WebKit/commit/58f6c8c908495ef98006509e0142d15225c64be9 Author: Javier Fernandez <jfernan...@igalia.com> Date: 2023-08-22 (Tue, 22 Aug 2023)
Changed paths: M LayoutTests/crypto/subtle/import-key-malformed-parameters-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed448.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed448.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X25519.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X25519.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X448.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X448.https.any.worker-expected.txt M Source/WebCore/crypto/JsonWebKey.idl Log Message: ----------- Remove the 'required' flag in the JsonWebKey's 'kty' field https://bugs.webkit.org/show_bug.cgi?id=260430 Reviewed by Youenn Fablet. Marking the 'kty' field as required causes that we throw a TypeError exception during the IDL-JS type mapping phase. However, the specs of the different algorithms state that we should throw a DataError instead. By removing the 'required' flag of the mentioned field we allow the implementation of each algorithm to deal with the issue, detecting either the lack of that mandatory field or an incorrect value for the specific algorithm. It's worth mentioning that the current implementation of the algorithms already performs the required checks, throwing a DataError exception as the spec states. Hence, this change just avoids the early checks and let the algorithms execute their specific logic. * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed448.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed448.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X25519.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X25519.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X448.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X448.https.any.worker-expected.txt: * Source/WebCore/crypto/JsonWebKey.idl: Canonical link: https://commits.webkit.org/267131@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes