Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c25cad683ccc1832ce4f12f283a032a2be9f4ac https://github.com/WebKit/WebKit/commit/5c25cad683ccc1832ce4f12f283a032a2be9f4ac Author: Megan Gardner <megan_gard...@apple.com> Date: 2024-07-08 (Mon, 08 Jul 2024)
Changed paths: M Source/WebCore/editing/CharacterRange.h M Source/WebCore/page/ChromeClient.h M Source/WebCore/page/writing-tools/WritingToolsController.h M Source/WebCore/page/writing-tools/WritingToolsController.mm M Source/WebKit/Shared/TextAnimationType.serialization.in M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/TextAnimationType.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm M Source/WebKit/WebKitSwift/TextAnimation/TextAnimationManager.swift M Source/WebKit/WebKitSwift/TextAnimation/WKSTextAnimationSourceDelegate.h M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm Log Message: ----------- Text replacement animations do not run in the correct order and fail to animate over the correct ranges when text comes in over time. https://bugs.webkit.org/show_bug.cgi?id=276113 rdar://128292335 Reviewed by Aditya Keerthi and Wenson Hsieh. I was not using the full async animation infrastructure and the tracking of the different ranges as the different chunks came in was not correct. These changes should streamline the animations and correct some not-as-good names for some of the variables. There are still some frames that need a bit of polish, but this is a much better working version than we have had up to this point. * Source/WebCore/editing/CharacterRange.h: (WebCore::CharacterRange::operator== const): * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::addSourceTextAnimation): * Source/WebCore/page/writing-tools/WritingToolsController.h: * Source/WebCore/page/writing-tools/WritingToolsController.mm: (WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRange): * Source/WebKit/Shared/TextAnimationType.serialization.in: * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::addTextAnimationForAnimationID): (WebKit::WebPageProxy::callCompletionHandlerForAnimationID): (WebKit::WebPageProxy::getTextIndicatorForID): * Source/WebKit/UIProcess/TextAnimationType.h: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm: (-[WKTextAnimationManager addTextAnimationForAnimationID:withData:]): (-[WKTextAnimationManager textPreviewsForChunk:completion:]): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::addSourceTextAnimation): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h: * Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm: (WebKit::TextAnimationController::unreplacedRangeForSessionWithID const): (WebKit::TextAnimationController::contextRangeForTextAnimationID const): (WebKit::TextAnimationController::removeTransparentMarkersForSessionID): (WebKit::remainingCharacterRange): (WebKit::TextAnimationController::addInitialTextAnimation): (WebKit::TextAnimationController::addSourceTextAnimation): (WebKit::TextAnimationController::addDestinationTextAnimation): (WebKit::TextAnimationController::updateUnderlyingTextVisibilityForTextAnimationID): (WebKit::newlyReplacedCharacterRange): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::addTextAnimationForAnimationID): (WebKit::WebPage::addSourceTextAnimation): * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/280763@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes