Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5daecebaee8344378f5d4db67f14422fe06029ea https://github.com/WebKit/WebKit/commit/5daecebaee8344378f5d4db67f14422fe06029ea Author: Tadeu Zagallo <tzaga...@apple.com> Date: 2024-03-01 (Fri, 01 Mar 2024)
Changed paths: A LayoutTests/http/tests/webgpu/webgpu/shader/validation/decl/var-expected.txt M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: ----------- [WGSL] Refactor variable initializer typing https://bugs.webkit.org/show_bug.cgi?id=270316 rdar://123854264 Reviewed by Mike Wyrzykowski. In 274615@main I fixed the failing CTS tests under shader,validation,decl,var:initializer_kind: by adding explicit checks for function calls and references to other global variables. However, the reason those tests were failing in the first place was that a global variable's initializer can only use constant and override expressions according to the spec[1]. [1]: https://www.w3.org/TR/WGSL/#var-and-value * LayoutTests/http/tests/webgpu/webgpu/shader/validation/decl/var-expected.txt: Added. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): (WGSL::TypeChecker::visitVariable): Deleted. Canonical link: https://commits.webkit.org/275554@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes