Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e4935006d800fff897c52435b38db22ef2ced70
      
https://github.com/WebKit/WebKit/commit/5e4935006d800fff897c52435b38db22ef2ced70
  Author: Miguel Gomez <mago...@igalia.com>
  Date:   2024-04-01 (Mon, 01 Apr 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp
    M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp

  Log Message:
  -----------
  [WPE] Holepunch doesn't work when the video element has rounded corners
https://bugs.webkit.org/show_bug.cgi?id=271653

Reviewed by Carlos Garcia Campos.

Modify the rounded rectangle clipping in the TextureMapper so it can work
when blending is disabled. To do this, the fragments that are out of rounded
rectangle are discarded by the fragment shader, instead of painting them
transparent.

When blending is enabled, we can do some antialiasing of the pixels on the
rounded corners by reducing their opacity depending on how much they are
inside the rect.

When blending is disabled we can't do antialiasing of the rounded corners,
so the visual result is a bit worse. The good thing is that blending is
only disabled when we're rendering a holepunch buffer, so it's not a big
problem.

* Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::drawSolidColor):
* Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Canonical link: https://commits.webkit.org/276876@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to