Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d890dea244d3c6ab908b53ee3cfb52722b38572
https://github.com/WebKit/WebKit/commit/6d890dea244d3c6ab908b53ee3cfb52722b38572
Author: Devin Rousso <h...@devinrousso.com>
Date: 2023-04-13 (Thu, 13 Apr 2023)
Changed paths:
M LayoutTests/inspector/runtime/getPreview-expected.txt
M LayoutTests/inspector/runtime/getPreview.html
M Source/JavaScriptCore/inspector/InjectedScriptSource.js
M Source/JavaScriptCore/inspector/protocol/Runtime.json
M Source/WebInspectorUI/UserInterface/Models/PropertyPreview.js
M Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.css
M Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js
Log Message:
-----------
Web Inspector: Console: internal properties are not greyed out in object
previews
https://bugs.webkit.org/show_bug.cgi?id=255385
Reviewed by Patrick Angle.
We should have a consistent style between previews and actual remmote object
views.
Otherwise, internal properties appear as regular properties in the preview, but
then look different when the object view is expanded.
* Source/JavaScriptCore/inspector/protocol/Runtime.json:
* Source/JavaScriptCore/inspector/InjectedScriptSource.js:
(RemoteObject.prototype._appendPropertyPreview.appendPreview):
* Source/WebInspectorUI/UserInterface/Models/PropertyPreview.js:
(WI.PropertyPreview):
(WI.PropertyPreview.fromPayload):
(WI.PropertyPreview.prototype.get private): Added.
Include an `isPrivate` property in `Runtime.PropertyPreview`.
Drive-by: Refactor `WI.PropertyPreview` to put all optional properties into a
`{...} = {}`.
* Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js:
(WI.ObjectPreviewView.prototype._appendPropertyPreviews):
* Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.css:
(.object-preview .name:is(.private, .internal)): Added.
Style private and internal property previews.
* LayoutTests/inspector/runtime/getPreview.html:
* LayoutTests/inspector/runtime/getPreview-expected.txt:
Canonical link: https://commits.webkit.org/262924@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
