Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7706664bf8e1ca841670d2e6f23e8253d57f3f6e https://github.com/WebKit/WebKit/commit/7706664bf8e1ca841670d2e6f23e8253d57f3f6e Author: Simon Fraser <simon.fra...@apple.com> Date: 2024-03-29 (Fri, 29 Mar 2024)
Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/Plugins/PluginView.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: ----------- [PDF] Clean up some scales and #ifdefs in PDFPlugin code https://bugs.webkit.org/show_bug.cgi?id=271912 rdar://125630155 Reviewed by Tim Horton. Various minor bits of cleanup in PDFPlugin code: 1. Make all the scales be doubles 2. Make `contentScaleFactor()` internal to PDFPluginBase and subclasses, requiring some annotation classes to be friends. Stop exposing it via PluginView. 3. Change some ENABLE(LEGACY_PDFKIT_PLUGIN) to ENABLE(PDF_PLUGIN) for classes that are still used with UnifiedPDF * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::showDefinitionForAttributedString): (WebKit::PDFPlugin::scaleFactor const): (WebKit::PDFPlugin::contentScaleFactor const): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: (WebKit::PDFPluginBase::didEndMagnificationGesture): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::dictionaryPopupInfoForSelection): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::scaleForActualSize const): (WebKit::UnifiedPDFPlugin::scaleForFitToView const): (WebKit::UnifiedPDFPlugin::initialScale const): (WebKit::UnifiedPDFPlugin::scaleFactor const): (WebKit::UnifiedPDFPlugin::contentScaleFactor const): (WebKit::UnifiedPDFPlugin::centeringOffset const): * Source/WebKit/WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::contentScaleFactor const): Deleted. * Source/WebKit/WebProcess/Plugins/PluginView.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::pageZoomFactor const): (WebKit::WebPage::setPageZoomFactor): Canonical link: https://commits.webkit.org/276855@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes