Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 78482a0a9019d7b95034ebe3f934d71633fc2788
https://github.com/WebKit/WebKit/commit/78482a0a9019d7b95034ebe3f934d71633fc2788
Author: Tadeu Zagallo <tzaga...@apple.com>
Date: 2023-09-19 (Tue, 19 Sep 2023)
Changed paths:
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
Log Message:
-----------
[WGSL] MetalFunctionWriter needs to explicitly visit CallStatement
https://bugs.webkit.org/show_bug.cgi?id=261757
rdar://115735246
Reviewed by Dan Glastonbury.
CallStatement was introduced in 268076@main, and while it seemed that it should
be handled
by the default ASTVisitor implementation, it doesn't work for
MetalFunctionWriter since it
doesn't explicitly implement the visitor for CallExpression. This caused the
ASTVisitor
default implementation for CallExpression to be used instead, which resulted in
an incorrect
serialization of call statements. This could be fixed by adding either of those
visitors
(CallStatement or Expression), and I chose to implement it for CallStatement,
since we
already have an implementation for CallExpression, but with a different
signature.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
Canonical link: https://commits.webkit.org/268174@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
