Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ab89ec17812da9b0187990f789cf32fad6cdff7 https://github.com/WebKit/WebKit/commit/7ab89ec17812da9b0187990f789cf32fad6cdff7 Author: Dewei Zhu <dewei_...@apple.com> Date: 2024-07-09 (Tue, 09 Jul 2024)
Changed paths: M Websites/perf.webkit.org/public/include/uploaded-file-helpers.php M Websites/perf.webkit.org/server-tests/privileged-api-upload-file-tests.js M Websites/perf.webkit.org/server-tests/resources/test-server.js Log Message: ----------- Fix a bug that a root for an A/B test can be pruned during A/B test creation https://bugs.webkit.org/show_bug.cgi?id=276265 rdar://122118306 Reviewed by Ryosuke Niwa. Fix a bug that a root uploaded during creation of an A/B test can be pruned because of other root upload for current test or other tests by introducing 'uploadFileGracePeriodInHours' config. Fix a pruning issue that file can be double counted during pruning because a root can be referenced by multiple commit sets. Improve a pruning query to use 'commitset_requires_build' isntead of 'commitset_patch_file IS NOT NULL' to determine if a root is built for a configuration. This increase the accuracy of the query because a build request will be built if the other side of build request requires building. Fix a bug that API response for '/api/upload-root' may contain stale file information if re-upload happens. Update file creation time while re-uploading a pruned file so that it will qualify the grace period for a new uploaded file. * Websites/perf.webkit.org/public/include/uploaded-file-helpers.php: Add support for 'uploadFileGracePeriodInHours'. Fix a bug that '/api/upload-root' does not return latest information for a re-uploaded file. Fix and improve the pruning query. * Websites/perf.webkit.org/server-tests/privileged-api-upload-file-tests.js: Fix and add unit tests. * Websites/perf.webkit.org/server-tests/resources/test-server.js: Add support to overwrite test config. (TestServer.prototype.start): (TestServer.prototype.writeTestConfig): (TestServer.prototype.overwriteTestConfig): (TestServer.prototype.inject): (TestServer): Canonical link: https://commits.webkit.org/280806@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes