Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f94f5d99e7a8b1391febeec42959e7c703f5bdd
      
https://github.com/WebKit/WebKit/commit/7f94f5d99e7a8b1391febeec42959e7c703f5bdd
  Author: Sihui Liu <sihui_...@apple.com>
  Date:   2024-04-19 (Fri, 19 Apr 2024)

  Changed paths:
    M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  -----------
  http/tests/cookies/private-cookie-storage.html fails when site isolation is 
enabled
https://bugs.webkit.org/show_bug.cgi?id=272856
rdar://126647153

Reviewed by Alex Christensen.

The test switches sessions on navigation (with TestRunner 
setShouldSwapToDefaultSessionOnNextNavigation and
setShouldSwapToEphemeralSessionOnNextNavigation) and thus swaps web processes 
on navigation (because each web process is
tied with one WebsiteDataStore/session). The test fails with site isolation 
enabled as UI process does not pick web
process with target WebsiteDataStore for navigation. To fix that, this patch 
ensure to check WebsiteDataStore of
WebProcessProxy before using it.

* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::ensureProcessForDomain):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processForRegistrableDomain):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):

Canonical link: https://commits.webkit.org/277757@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to